Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BREAKING) refactor: rename dropWorst option to warmupRuns #401

Merged
merged 2 commits into from
May 9, 2023

Conversation

mdjastrzebski
Copy link
Member

Summary

Based on the developer feedback the dropWorst parameter was not well named nor understood. This PR changes the name to warmupRuns and slightly tweak the logic to discard first runs and not the highest runes (these were usually the same runs).

Test plan

Relevant tests have been tweaked.

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023

🦋 Changeset detected

Latest commit: ace21d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@callstack/reassure-measure Minor
reassure Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mdjastrzebski mdjastrzebski changed the title (BREAKING) refactor: rename dropWorst to warmupRuns (BREAKING) refactor: rename dropWorst option to warmupRuns May 9, 2023
@mdjastrzebski mdjastrzebski requested review from Xiltyn and thymikee and removed request for Xiltyn May 9, 2023 10:06
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Performance Comparison Report

  • Current: 72bb044 - 2023-05-09 10:11:00Z
  • Baseline: main (baf90de) - 2023-05-09 10:10:20Z

Significant Changes To Render Duration

Name Render Duration Render Count
Async Component 252.3 ms → 243.0 ms (-9.3 ms, -3.7%) 7 → 7
Show details
Name Render Duration Render Count
Async Component Baseline
Mean: 252.3 ms
Stdev: 6.8 ms (2.7%)
Runs: 264 258 256 255 254 252 251 249 243 241

Current
Mean: 243.0 ms
Stdev: 9.4 ms (3.9%)
Runs: 259 252 249 246 244 242 240 240 230 228
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Other Component 20 151.5 ms → 151.0 ms (-0.5 ms, ±0.0%) 4 → 4
Other Component 10 149.4 ms → 146.9 ms (-2.5 ms, -1.7%) 4 → 4
Other Component 10 legacy scenario 152.7 ms → 150.1 ms (-2.6 ms, -1.7%) 4 → 4
Show details
Name Render Duration Render Count
Other Component 20 Baseline
Mean: 151.5 ms
Stdev: 5.2 ms (3.5%)
Runs: 159 159 157 157 156 156 154 154 154 152 152 151 150 149 147 147 146 145 144 141

Current
Mean: 151.0 ms
Stdev: 4.9 ms (3.3%)
Runs: 164 160 156 154 154 153 152 151 151 150 150 150 150 148 148 147 147 146 145 144
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Other Component 10 Baseline
Mean: 149.4 ms
Stdev: 6.4 ms (4.3%)
Runs: 155 155 155 155 152 150 147 145 144 136

Current
Mean: 146.9 ms
Stdev: 6.9 ms (4.7%)
Runs: 159 153 153 151 146 145 144 142 138 138
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Other Component 10 legacy scenario Baseline
Mean: 152.7 ms
Stdev: 7.5 ms (4.9%)
Runs: 161 160 159 158 154 153 152 149 142 139

Current
Mean: 150.1 ms
Stdev: 7.2 ms (4.8%)
Runs: 164 157 156 152 150 148 145 144 143 142
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against ace21d9

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's better

@mdjastrzebski mdjastrzebski merged commit ea70aab into main May 9, 2023
@mdjastrzebski mdjastrzebski deleted the refactor/rename-warmup-runs branch May 9, 2023 14:30
@mdjastrzebski mdjastrzebski mentioned this pull request May 9, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants