Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: tweaks #524

Merged
merged 2 commits into from
Aug 28, 2024
Merged

docs: tweaks #524

merged 2 commits into from
Aug 28, 2024

Conversation

mdjastrzebski
Copy link
Member

Summary

Tweaks docs to reflect recent changes.

Test plan

Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: 89043be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 28, 2024

Performance Comparison Report

  • Current: HEAD (f959c3f) - 2024-08-28 13:54:35Z
  • Baseline: main (018cd40) - 2024-08-28 13:53:43Z

Significant Changes To Duration

Name Type Duration Count
Other Component 10 render 70.3 ms → 66.1 ms (-4.2 ms, -6.0%) 🟢 4 → 4
fib 32 function 101.9 ms → 96.3 ms (-5.6 ms, -5.5%) 🟢 1 → 1
Show details
Name Type Duration Count
Other Component 10 render Baseline
Mean: 70.3 ms
Stdev: 2.3 ms (3.2%)
Runs: 69 74 72 71 69 67 71 73 69 68
Warmup runs: 278

Current
Mean: 66.1 ms
Stdev: 3.7 ms (5.6%)
Runs: 65 66 68 72 63 66 65 71 66 59
Warmup runs: 78
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
fib 32 function Baseline
Mean: 101.9 ms
Stdev: 0.9 ms (0.9%)
Runs: 100.6 100.9 101.0 101.6 102.2 102.1 103.6 102.3 102.0 102.3
Warmup runs: 100.9

Current
Mean: 96.3 ms
Stdev: 2.0 ms (2.0%)
Runs: 95.2 95.6 95.1 97.4 93.6 96.2 96.8 100.2 98.2 94.3
Warmup runs: 98.6
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Async Component render 107.9 ms → 104.2 ms (-3.7 ms, -3.4%) 7 → 7
fib 30 function 37.4 ms → 38.5 ms (+1.1 ms, +2.9%) 1 → 1
fib 31 function 63.4 ms → 60.1 ms (-3.3 ms, -5.2%) 1 → 1
InitialRenders 1 render 0.8 ms → 0.8 ms 2 → 2
InitialRenders 3 render 1.3 ms → 1.4 ms (+0.1 ms, +7.7%) 4 → 4
ManyRenderIssues render 1.6 ms → 1.6 ms 5 → 5
Other Component 10 legacy scenario render 66.8 ms → 66.4 ms (-0.4 ms, -0.6%) 4 → 4
Other Component 20 render 65.0 ms → 63.0 ms (-2.0 ms, -3.1%) 4 → 4
RedundantUpdates render 0.7 ms → 1.0 ms (+0.3 ms, +42.9%) 🔴 2 → 2
Show details
Name Type Duration Count
Async Component render Baseline
Mean: 107.9 ms
Stdev: 5.1 ms (4.7%)
Runs: 105 109 106 112 110 106 113 96 113 109
Warmup runs: 105

Current
Mean: 104.2 ms
Stdev: 7.5 ms (7.2%)
Runs: 98 107 112 105 110 97 108 115 92 98
Warmup runs: 107
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1
fib 30 function Baseline
Mean: 37.4 ms
Stdev: 3.3 ms (8.8%)
Runs: 36.0 36.3 36.3 36.6 36.5 36.4 36.5 36.4 36.5 46.7
Warmup runs: 36.5

Current
Mean: 38.5 ms
Stdev: 1.0 ms (2.6%)
Runs: 39.0 37.5 39.0 39.0 37.0 40.1 38.4 37.2 39.0 39.0
Warmup runs: 36.2
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 31 function Baseline
Mean: 63.4 ms
Stdev: 1.2 ms (1.8%)
Runs: 62.5 63.0 63.1 63.1 63.0 63.0 66.6 63.1 63.1 63.9
Warmup runs: 62.1

Current
Mean: 60.1 ms
Stdev: 2.3 ms (3.8%)
Runs: 57.7 57.8 62.9 60.8 58.3 60.5 58.8 63.2 63.1 58.2
Warmup runs: 60.1
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
InitialRenders 1 render Baseline
Mean: 0.8 ms
Stdev: 0.4 ms (52.7%)
Runs: 1 1 1 0 1 1 0 1 1 1
Warmup runs: 1

Current
Mean: 0.8 ms
Stdev: 0.4 ms (52.7%)
Runs: 1 1 1 1 1 0 1 1 1 0
Warmup runs: 1
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1
InitialRenders 3 render Baseline
Mean: 1.3 ms
Stdev: 0.7 ms (51.9%)
Runs: 2 0 1 2 2 1 1 1 2 1
Warmup runs: 2

Current
Mean: 1.4 ms
Stdev: 0.7 ms (49.9%)
Runs: 2 1 1 2 2 2 1 0 1 2
Warmup runs: 2
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3
ManyRenderIssues render Baseline
Mean: 1.6 ms
Stdev: 1.0 ms (60.4%)
Runs: 2 2 1 1 1 1 0 3 2 3
Warmup runs: 1

Current
Mean: 1.6 ms
Stdev: 0.5 ms (32.3%)
Runs: 1 2 2 2 2 1 1 2 1 2
Warmup runs: 3
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)
Other Component 10 legacy scenario render Baseline
Mean: 66.8 ms
Stdev: 3.7 ms (5.6%)
Runs: 63 70 69 70 65 66 64 64 63 74
Warmup runs: 64

Current
Mean: 66.4 ms
Stdev: 4.2 ms (6.3%)
Runs: 66 74 65 69 65 64 61 61 71 68
Warmup runs: 62
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Other Component 20 render Baseline
Mean: 65.0 ms
Stdev: 4.3 ms (6.6%)
Runs: 65 60 66 71 62 65 66 66 62 62 71 63 63 58 75 64 67 67 69 59
Warmup runs: 61

Current
Mean: 63.0 ms
Stdev: 4.8 ms (7.6%)
Runs: 60 67 62 63 70 57 63 68 65 56 65 64 61 60 76 58 60 65 59 62
Warmup runs: 61
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
RedundantUpdates render Baseline
Mean: 0.7 ms
Stdev: 0.5 ms (69.0%)
Runs: 1 0 1 0 1 0 1 1 1 1
Warmup runs: 0

Current
Mean: 1.0 ms
Stdev: 0.8 ms (81.6%)
Runs: 0 0 0 1 1 1 2 2 1 2
Warmup runs: 1
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Render Count Changes

There are no entries

Render Issues

Name Initial Updates Redundant Updates
Other Component 10 1 🔴 -
Other Component 10 legacy scenario 1 🔴 -
Other Component 20 1 🔴 -
InitialRenders 1 1 🔴 -
InitialRenders 3 3 🔴 -
RedundantUpdates - 1 (1) 🔴
ManyRenderIssues 2 🔴 2 (3, 4) 🔴
Async Component 1 🔴 -

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 89043be

@mdjastrzebski mdjastrzebski merged commit f26ca41 into main Aug 28, 2024
2 checks passed
@mdjastrzebski mdjastrzebski deleted the docs/cli-options-update branch August 28, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant