-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Databricks Support #100
Comments
Hi @phillem15! I'd love to offer to support for spark and databricks for dbt-date and dbt-expectations. It's not so much a matter of writing compatible SQL, but a matter of being able to test against these platforms. We are currently only able to run CI/CD against Postgres, BigQuery and Snowflake. As a result, in the past, we've deferred support for non-core platforms (like spark, or MS SQL) to utils packages for those platforms as shims. |
Hi @clausherther, that makes total sense. I'd be happy to help! It looks like you are using circleci for this? That is a tool I have not used before but if you could point me in the right direction I'd be happy to learn more and help get that set up. |
My concern is really around hosting a databricks instance to run the tests on (and ideally also hosting a spark instance). I currently maintain the BigQuery and Snowflake instances we test on (Postgres is created on the fly during CI/CD). |
Another issue I've had in the past is the databricks Community Edition clusters get dropped after 2 hours of inactivity, so for CI/CD to work one would have to programmatically created a cluster etc. |
We didn't realise it didn't support Databricks and have been using 0.5.7 for months. I tried to upgrade to 0.7.2 today and so far no errors noticed. This is without doing the recommended "shim package" because we didn't realise it was expected
Maybe we are just the package to a limited extent. Are we aware of anything not working? |
Regarding integration tests, since at least Spark SQL is open source, wouldn't it be possible to instantiating spark on the CI/CI worker and run the tests there? |
Still not planned? |
Not until someone can figure out how to hook up our CI tests to databricks without needing a paid account. Last I checked this wasn't doable. |
(To be clear, we've had dbt-spark support for a while, just not databricks.) |
I have been using this with Databricks since support for spark came out and only had one issue with one of the month macros but I believe that was fixed in 0.10.1.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Claus Herther ***@***.***>
Sent: Thursday, June 6, 2024 9:03:52 AM
To: calogica/dbt-date ***@***.***>
Cc: Evan Phillips ***@***.***>; Mention ***@***.***>
Subject: Re: [calogica/dbt-date] Databricks Support (Issue #100)
(To be clear, we've had dbt-spark support for a while, just not databricks.)
—
Reply to this email directly, view it on GitHub<#100 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKXOBJ3BXUKLFNOXUZUAMHTZGBT4RAVCNFSM6AAAAABI4IV7TOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJSGYZDMMRTGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Good to hear. Just keep in mind that since we can't test changes on databricks, it's possible that future releases may break databricks compatibility. |
@clausherther I will ping them to see how they can support OSS projects |
Is your feature request related to a problem? Please describe.
It is not related to a problem.
Describe the solution you'd like
I would like for there to be support for Databricks.
Describe alternatives you've considered
I have considered forking this repo and adding support for databricks.
Additional context
The text was updated successfully, but these errors were encountered: