Update and review of maintainers.md file #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdamker
requested review from
diegogonmar,
jpengar,
chrishowell,
AxelNennker,
SyeddR,
shilpa-padgaonkar,
eric-murray,
FrimanJan and
MarkCornall
jpengar
approved these changes
May 15, 2024
There was a problem hiding this comment.
LGTM according to what I see in camaraproject/Governance#134 and in other closed PRs such as camaraproject/SimSwap#106 or camaraproject/SiteToCloudVPN#16
AxelNennker
approved these changes
May 15, 2024
MarkCornall
approved these changes
May 15, 2024
|
We are good to go. If there are needs to change, just open an PR against the MAINTAINERS.md file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
See
Beside adding the GitHubname, the PR reflects the changes at Telefonica and DT, please review if there are more changes needed.
Which issue(s) this PR fixes:
Fixes #151
Special notes for reviewers:
@sachinvodafone @shilpa-padgaonkar please accept the invitation from GitHub to get a member of the camaraproject organization, so that you get a member of the team @camaraproject/identity-and-consent-management_maintainers