Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of info, servers objects and security scope names #114

Merged
merged 5 commits into from
Jul 26, 2024

Conversation

rartych
Copy link
Collaborator

@rartych rartych commented Jul 22, 2024

What type of PR is this?

  • correction

What this PR does / why we need it:

Alignment of info and servers objects and security scope names with API Design Guidelines

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Changelog input

Corrected info, servers objects and security scope names

Additional documentation

https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#info-object

https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#servers-object

https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#52-api-version-in-url-oas-servers-object

Security scope names according API Design Guidellines https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#1161-scope-naming

Modifying info and servers object according to API Design Guidelines
Modifying info and servers object according to API Design Guidelines
GillesInnov35
GillesInnov35 previously approved these changes Jul 23, 2024
urls in servers object corrected to vwip

Co-authored-by: Herbert Damker <[email protected]>
Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ToshiWakayama-KDDI
Copy link
Collaborator

Hi @rartych , @fernandopradocabrillo , @GillesInnov35 , @jgarciahospital ,

I have just approved this. Can I merge this PR now?

BR
Toshi

@ToshiWakayama-KDDI ToshiWakayama-KDDI merged commit a5258d8 into camaraproject:main Jul 26, 2024
@ToshiWakayama-KDDI
Copy link
Collaborator

Just merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants