generated from camaraproject/Template_API_Repository
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alignment of info, servers objects and security scope names #114
Merged
ToshiWakayama-KDDI
merged 5 commits into
camaraproject:main
from
rartych:rartych-info-servers
Jul 26, 2024
Merged
Alignment of info, servers objects and security scope names #114
ToshiWakayama-KDDI
merged 5 commits into
camaraproject:main
from
rartych:rartych-info-servers
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifying info and servers object according to API Design Guidelines
Modifying info and servers object according to API Design Guidelines
Security scope names according API Design Guidellines https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#1161-scope-naming
Security scope names according API Design Guidellines https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#1161-scope-naming
rartych
requested review from
ToshiWakayama-KDDI,
fernandopradocabrillo and
GillesInnov35
as code owners
July 22, 2024 19:14
GillesInnov35
previously approved these changes
Jul 23, 2024
hdamker
reviewed
Jul 23, 2024
hdamker
reviewed
Jul 23, 2024
urls in servers object corrected to vwip Co-authored-by: Herbert Damker <[email protected]>
GillesInnov35
approved these changes
Jul 24, 2024
fernandopradocabrillo
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hdamker
approved these changes
Jul 24, 2024
ToshiWakayama-KDDI
approved these changes
Jul 25, 2024
Hi @rartych , @fernandopradocabrillo , @GillesInnov35 , @jgarciahospital , I have just approved this. Can I merge this PR now? BR |
Just merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Alignment of
info
andservers
objects and security scope names with API Design GuidelinesWhich issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Changelog input
Additional documentation
https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#info-object
https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#servers-object
https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#52-api-version-in-url-oas-servers-object
Security scope names according API Design Guidellines https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#1161-scope-naming