Fixed Test Definition and patch release r1.3 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed code:
@NumberVerification_phone_number_share201_missing_scope
Changed code to PERMISSION_DENIED (previous was UNAUTHENTICATED )
@NumberVerification_phone_number_share202_expired_access_token
Changed code to UNAUTHENTICATED (previous was AUTHENTICATION_REQUIRED )
Fixed code for 2 scenarios:
@NumberVerification_verify201_missing_scope
Changed code to PERMISSION_DENIED (previous was UNAUTHENTICATED )
@NumberVerification_verify202_expired_access_token
Changed code to UNAUTHENTICATED (previous was AUTHENTICATION_REQUIRED )
Change r1.2t to r1.3 Fixed link to the wiki
Changed in title to r1.3
Introduce r1.3 with Test Definition fixing.
bigludo7
requested review from
fernandopradocabrillo and
AxelNennker
as code owners
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Add PR reference
hdamker
changed the title
hdamker
added
bug
12 tasks
|
@bigludo7 looks good to me. Regarding the CHANGELOG my understanding is that in case of patch release only the changes towards the last public release need to be listed (which is r1.2). At least that is the practice within e.g. https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.30.md and also in line with our CHANGELOG template:
@tanjadegroot any further thoughts on that? |
code/Test_Definitions/number-verification-device-phone-number-share.feature
Outdated
Show resolved
Hide resolved
code/Test_Definitions/number-verification-device-phone-number-share.feature
Outdated
Show resolved
Hide resolved
…share.feature Co-authored-by: Fernando Prado Cabrillo <[email protected]>
Co-authored-by: Fernando Prado Cabrillo <[email protected]>
Co-authored-by: Fernando Prado Cabrillo <[email protected]>
…share.feature Co-authored-by: Fernando Prado Cabrillo <[email protected]>
|
Thanks @fernandopradocabrillo for the review !!! |
|
If we are not going to dismiss the r1.2 then I think @hdamker is right and in the changelog we should only include what is new in the r1.2 |
Remove from the changelog in the r1.3 the information from the r1.2
|
@fernandopradocabrillo @hdamker Updated the changelog to follow your recommendation. |
|
@camaraproject/release-management_maintainers @AxelNennker Kind reminder as this one should be quickly merged. Thanks |
hdamker
previously approved these changes
Oct 1, 2024
Co-authored-by: Herbert Damker <[email protected]>
Co-authored-by: Herbert Damker <[email protected]>
Remove main change part
fernandopradocabrillo
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This PR fixes following Test Case definition to be aligned with the yaml & other API:
@NumberVerification_phone_number_share201_missing_scope
Changed code to PERMISSION_DENIED (previous was UNAUTHENTICATED )
@NumberVerification_phone_number_share202_expired_access_token
Changed code to UNAUTHENTICATED (previous was AUTHENTICATION_REQUIRED )
@NumberVerification_verify201_missing_scope
Changed code to PERMISSION_DENIED (previous was UNAUTHENTICATED )
@NumberVerification_verify202_expired_access_token
Changed code to UNAUTHENTICATED (previous was AUTHENTICATION_REQUIRED )
Which issue(s) this PR fixes:
Fixes #147
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.