Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding puml #24

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Conversation

DT-DawidWroblewski
Copy link
Collaborator

uml sequence diagram for MC Number Verify

bigludo7
bigludo7 previously approved these changes Feb 27, 2023
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dawid - This is helpful.

documentation/UML/sequenceDiagram.puml Outdated Show resolved Hide resolved
activate user
user -> mApp: opens Developer's App
activate mApp
mApp -> auth: scope=openid mc_verified_msisdn\n&state={...}\n&{query params defined inside MC specs}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the scopes I was told in other working groups that we have to wait till we get into an agreements for scopes in commonalities so we avoid inconsistancy in CAMARA project. What do you think about this point @DT-DawidWroblewski @bigludo7 ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me when the scope has been already defined in the standard - Mobile Connect for example - we have to take it as such to avoid confusion for implementation knowing it. I guess this is the case here.

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this is good pending @monamok point.
Thanks

activate user
user -> mApp: opens Developer's App
activate mApp
mApp -> auth: scope=openid mc_verified_msisdn\n&state={...}\n&{query params defined inside MC specs}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me when the scope has been already defined in the standard - Mobile Connect for example - we have to take it as such to avoid confusion for implementation knowing it. I guess this is the case here.

@bigludo7 bigludo7 self-requested a review March 9, 2023 07:49
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me

@DT-DawidWroblewski DT-DawidWroblewski merged commit 67e534d into camaraproject:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants