Extend session duration #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new operation to extend session duration
emil-cheung
requested review from
hdamker,
eric-murray and
RandyLevensalor
as code owners
emil-cheung
changed the title
emil-cheung
changed the title
jlurien
reviewed
Sep 22, 2023
eric-murray
reviewed
Nov 14, 2023
code/API_definitions/qod-api.yaml
Outdated
| /sessions/{sessionId}/extend: | ||
| post: | ||
| tags: | ||
| - Change session duration |
There was a problem hiding this comment.
Tag should be Title Case, but it's not clear to me why we need a new tag here
There was a problem hiding this comment.
I wouldn't add a new tag for this. Tags are intended to group operations and this operation can be part of the existing "QoS Sessions" tag.
eric-murray
reviewed
Nov 14, 2023
jlurien
reviewed
Nov 16, 2023
code/API_definitions/qod-api.yaml
Outdated
| /sessions/{sessionId}/extend: | ||
| post: | ||
| tags: | ||
| - Change session duration |
There was a problem hiding this comment.
I wouldn't add a new tag for this. Tags are intended to group operations and this operation can be part of the existing "QoS Sessions" tag.
Change the tags of extend session duration operation.
Co-authored-by: Jose Luis Urien <[email protected]>
|
@eric-murray @RandyLevensalor Please have a final view |
6 tasks
RandyLevensalor
approved these changes
Nov 20, 2023
|
No further comments since last week, so we are good here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
enhancement/feature
What this PR does / why we need it:
Extend the duration of an active session.
Which issue(s) this PR fixes:
Fixes #220
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.