Follow-up to PR kubernetes-sigs#4243: Limit permissions to access the…

… metrics-server-cert secret This change ensures that only the necessary permissions are granted for accessing the metrics-server-cert secret. Note that setting defaultMode: 420 is not required.
camilamacedo86 · Nov 10, 2024 · 04a3f80 · 04a3f80
1 parent ad4afdb
commit 04a3f80
Show file tree

Hide file tree

Showing 8 changed files with 0 additions and 8 deletions.
diff --git a/...c/cronjob-tutorial/testdata/project/config/default/certmanager_metrics_manager_patch.yaml b/...c/cronjob-tutorial/testdata/project/config/default/certmanager_metrics_manager_patch.yaml
@@ -18,5 +18,4 @@ spec:
       volumes:
       - name: metrics-certs
         secret:
-          defaultMode: 420
           secretName: metrics-server-cert
diff --git a/...rc/getting-started/testdata/project/config/default/certmanager_metrics_manager_patch.yaml b/...rc/getting-started/testdata/project/config/default/certmanager_metrics_manager_patch.yaml
@@ -18,5 +18,4 @@ spec:
       volumes:
       - name: metrics-certs
         secret:
-          defaultMode: 420
           secretName: metrics-server-cert
diff --git a/...tiversion-tutorial/testdata/project/config/default/certmanager_metrics_manager_patch.yaml b/...tiversion-tutorial/testdata/project/config/default/certmanager_metrics_manager_patch.yaml
@@ -18,5 +18,4 @@ spec:
       volumes:
       - name: metrics-certs
         secret:
-          defaultMode: 420
           secretName: metrics-server-cert
diff --git a/docs/book/src/multiversion-tutorial/testdata/project/dist/install.yaml b/docs/book/src/multiversion-tutorial/testdata/project/dist/install.yaml
@@ -7981,7 +7981,6 @@ spec:
           secretName: webhook-server-cert
       - name: metrics-certs
         secret:
-          defaultMode: 420
           secretName: metrics-server-cert
 ---
 apiVersion: cert-manager.io/v1

diff --git a/...mize/v2/scaffolds/internal/templates/config/kdefault/certmanager_metrics_manager_patch.go b/...mize/v2/scaffolds/internal/templates/config/kdefault/certmanager_metrics_manager_patch.go
@@ -70,6 +70,5 @@ spec:
       volumes:
       - name: metrics-certs
         secret:
-          defaultMode: 420
           secretName: metrics-server-cert
 `
diff --git a/testdata/project-v4-multigroup/config/default/certmanager_metrics_manager_patch.yaml b/testdata/project-v4-multigroup/config/default/certmanager_metrics_manager_patch.yaml
@@ -18,5 +18,4 @@ spec:
       volumes:
       - name: metrics-certs
         secret:
-          defaultMode: 420
           secretName: metrics-server-cert
diff --git a/testdata/project-v4-with-plugins/config/default/certmanager_metrics_manager_patch.yaml b/testdata/project-v4-with-plugins/config/default/certmanager_metrics_manager_patch.yaml
@@ -18,5 +18,4 @@ spec:
       volumes:
       - name: metrics-certs
         secret:
-          defaultMode: 420
           secretName: metrics-server-cert
diff --git a/testdata/project-v4/config/default/certmanager_metrics_manager_patch.yaml b/testdata/project-v4/config/default/certmanager_metrics_manager_patch.yaml
@@ -18,5 +18,4 @@ spec:
       volumes:
       - name: metrics-certs
         secret:
-          defaultMode: 420
           secretName: metrics-server-cert