Skip to content

Commit

Permalink
First step to fix the Webpack tests
Browse files Browse the repository at this point in the history
  • Loading branch information
sbrunner committed Jan 31, 2018
1 parent 14efaef commit 86d86c5
Show file tree
Hide file tree
Showing 59 changed files with 3,184 additions and 2,640 deletions.
1 change: 0 additions & 1 deletion .eslintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ globals:
gmf: false
app: false
gmfapp: false
inject: false
jsts: false
moment: false
DateFormatter: false
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ jobs:
script:
- npm install
- npm install github:openlayers/openlayers#2ee34b825c4b5d6edd3569e10b3f63510754e012
- npm install github:gberaudo/googshift#977aceb
- buildtools/webpack-migration
- git add -A # for git-attributes
- if [ "${TRAVIS_PULL_REQUEST}" == false ]; then export NODE_ENV=prod; else export NODE_ENV=dev; fi
Expand All @@ -93,7 +94,7 @@ jobs:
- export CHROME_BIN=/opt/google/chrome/chrome
- export DISPLAY=:99.0
- sh -e /etc/init.d/xvfb start
- make test || true
- ./node_modules/karma/bin/karma start karma-conf.js --single-run || true
- cat .build/coverage/lcov.info || true
- make lint
- make check-examples-webpack
Expand Down
6 changes: 2 additions & 4 deletions buildtools/webpack-migration
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,10 @@ JSCS_ARGS="--non-default-import=ol,ol/proj,ol/proj/proj4,ol/dom,ol/array,ol/math
jscodeshift --transform=node_modules/googshift/transforms/goog_provide_to_goog_module.js $JSCS_ARGS src contribs/gmf/src examples contribs/gmf/examples test contribs/gmf/test contribs/gmf/apps
jscodeshift --transform=node_modules/googshift/transforms/goog_module_to_es6_module.js $JSCS_ARGS --absolute-module=true src contribs/gmf/src examples contribs/gmf/examples test contribs/gmf/test
jscodeshift --transform=node_modules/googshift/transforms/goog_module_to_es6_module.js $JSCS_ARGS contribs/gmf/apps
sed -i '/^if/d' src/proj/somerc.js src/proj/lcc.js src/proj/utm.js
sed -i '/^ ol/d' src/proj/somerc.js src/proj/lcc.js src/proj/utm.js
sed -i '/^}$/d' src/proj/somerc.js src/proj/lcc.js src/proj/utm.js
git add -A # To be removed when we use the new OpenLayers version
buildtools/git-grep-sed 'Sphere' 's|ol/Sphere|ol/sphere|g'
find -name node_modules -prune -or -name '*.js' -print | xargs sed -i 's|^// webpack: ||g'
find -name node_modules -prune -or -name '*.js' -print | xargs sed -i 's|// webpack: ||g'
find -name node_modules -prune -or -name '*.js' -print | xargs sed -i '/nowebpack$/d'
node_modules/.bin/eslint --fix src contribs/gmf/src examples contribs/gmf/examples test contribs/gmf/test contribs/gmf/apps || true
mv karma-conf{-webpack,}.js
mv src/{ngeo,index}.js
Expand Down
2 changes: 2 additions & 0 deletions buildtools/webpack.commons.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ const config = {
'../node_modules'
],
alias: {
'ngeo/test': path.resolve(__dirname, '../test/spec'),
'gmf/test': path.resolve(__dirname, '../contribs/gmf/test/spec'),
'ngeo': path.resolve(__dirname, '../src'),
'gmf': path.resolve(__dirname, '../contribs/gmf/src'),
'goog/asserts': path.resolve(__dirname, '../src/goog.asserts.js'),
Expand Down
15 changes: 15 additions & 0 deletions contribs/gmf/test/spec/all.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// webpack: import 'jquery';
// webpack: import 'angular';
// webpack: import 'angular-mocks';
import './beforeeach.js';
import './controllers/gmfprintcontroller.spec.js';
import './services/share.spec.js';
import './services/themesservice.spec.js';
import './services/syncLayertreeMap.spec.js';
import './services/authenticationservice.spec.js';
import './services/treemanager.spec.js';
import './services/thememanager.spec.js';
import './services/permalinkservice.spec.js';
import './directives/displayquerygrid.spec.js';
import './directives/displayquerywindow.spec.js';
import './directives/profile.spec.js';
4 changes: 1 addition & 3 deletions contribs/gmf/test/spec/beforeeach.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
/*eslint valid-jsdoc: 0 */

goog.require('gmf.theme.module');

beforeEach(() => {
const gmfModule = angular.module('gmf');
gmfModule.constant('angularLocaleScript', 'http://fake');
gmfModule.constant('gmfLayersUrl', 'https://fake');

module('gmf', ($provide) => {
angular.mock.module('gmf', ($provide) => {
$provide.value('gmfTreeUrl', 'http://fake/gmf/themes');
$provide.value('gmfShortenerCreateUrl', 'http://fake/gmf/short/create');
$provide.value('authenticationBaseUrl', 'https://fake/gmf/authentication');
Expand Down
5 changes: 2 additions & 3 deletions contribs/gmf/test/spec/controllers/gmfprintcontroller.spec.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* global printCapabilities */
goog.require('gmf.print.component');
goog.require('gmf.test.data.printcapabilities');
goog.require('ol.Map');
Expand All @@ -9,7 +8,7 @@ describe('GmfPrintController', () => {
let $controller, $rootScope, $scope;
let gmfPrintCtrl;

beforeEach(inject((_$controller_, _$rootScope_) => {
beforeEach(angular.mock.inject((_$controller_, _$rootScope_) => {
$controller = _$controller_;
$rootScope = _$rootScope_;
$scope = $rootScope.$new();
Expand All @@ -24,7 +23,7 @@ describe('GmfPrintController', () => {
})
});
gmfPrintCtrl.map.setSize([100, 100]);
gmfPrintCtrl.parseCapabilities_({data: printCapabilities});
gmfPrintCtrl.parseCapabilities_({data: gmf.test.data.printcapabilities});
}));

it('Get Set rotation', () => {
Expand Down
Loading

0 comments on commit 86d86c5

Please sign in to comment.