Adds some missing requires for annotations #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
approved these changes
Aug 21, 2017
|
Yes ... |
gberaudo
reviewed
Aug 21, 2017
| @@ -3,6 +3,8 @@ goog.provide('gmf.Permalink'); | |||
| goog.require('gmf'); | |||
| goog.require('ngeo'); | |||
| goog.require('ngeo.AutoProjection'); | |||
| /** @suppress {extraRequire} */ | |||
| goog.require('gmf.ObjectEditingManager'); | |||
There was a problem hiding this comment.
Ideally you should not require gmf.ObjectEditingManager here since it is an optionnal dependency.
There was a problem hiding this comment.
:-) then where, If I add it in the gmf.js, it's a requirement for all the module...
There was a problem hiding this comment.
For me it's an issue of closure-utils ...
Required by c2cgeoportal build on Docker
sbrunner
force-pushed
the
missing-requires
branch
from
4193139
to
809b95c
Compare
sbrunner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by c2cgeoportal build on Docker