-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support changing opacity and showing legend in mobile app #2923
Conversation
@ybolognini Would you please tell me the name of the font-awesome icon to use instead? |
@adube Please note that in the mockup, the two separator lines split completely the layer tree (whole column). The idea here was that the menu splits the layer tree and then comes back when the user closes the menu. We could even add an animation where the layer tree is being split (if easy to do) |
Thanks, I'll make the fix.
I'm not sure that's currently possible to do that. Please, anyone correct me if I'm wrong: the current UI is a tree, i.e. elements within elements with indentation. The "menu" (i.e. what's shown when the "cog" button is clicked" is part of the tree and therefore follows the identation. If we want the menu to be 100% width of the tree, then we would need to remove all the indentation of the tree. Please, confirm if that's what you want. |
src/directives/layertree.js
Outdated
return this.layer && | ||
( | ||
( | ||
this.depth === 1 && !this.node['mixed'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using the quoted notation, can you try to change this.node
type from Object
to gmfThemes.GmfGroup
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with an assert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't. This is a file from "ngeo". We can't put code from "gmf" there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbrunner can we do an exception for the externs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of changing the @type
here, these two function must be moved from ngeo
to gmf
Here's what's remaining to do:
I'll work on this soon. |
c027f71
to
5499cd9
Compare
6f9592a
to
b46f408
Compare
Probably just a missing asserts : https://travis-ci.org/camptocamp/ngeo/jobs/279666721#L1028-L1045 |
@adube thanks for your work on this; please merge |
Done. |
This PR introduces a "mobile" version of the tooltip that contains the opacity slider and "show/hide legend" that are in the desktop apps.
Instead of a tooltip, a plain div is shown underneath the node in the tree. A "cog" button has been added and is used to toggle on/off this menu.
Todo