-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import DataSource Restructuring (1) #2951
Conversation
b5df3d0
to
5e761d5
Compare
@fredj Ready for review. |
b5d5fbf
to
c0e5a4b
Compare
@fredj Do you know why Travis is failing? It seems to happen to me very often and I never really know why. If you do know why, I'd like to learn how to understand what's wrong to avoid asking that same question too many times. |
Just a reminder: I still don't know what's wrong with Travis. Any hint would be welcome. |
c0e5a4b
to
3c2c630
Compare
3c2c630
to
d93a477
Compare
on the deployement part:
and
|
@sbrunner Thanks. How were you able to see this? These errors are not reported by Travis. For me, locally, |
They are, but they are a bit hidden. To get the error what I usually do is:
|
|
3721283
to
f7efdd1
Compare
f2c7a1d
to
5ba9e31
Compare
@fredj The current error reported by Travis seems to be caused something that's not yet implemented in the compiler. Would you please investigate again? |
src/services/querent.js
Outdated
} else { | ||
features = dataSource.wmsFormat.readFeatures(response.data); | ||
features = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
semicolon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
2d9ac1e
to
7978ebe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please merge when travis is green
7978ebe
to
1219824
Compare
@fredj One last error reported by Travis. Do you know what's wrong? That doesn't seem related by my patch. |
See https://travis-ci.org/camptocamp/ngeo/jobs/287557316#L1271
|
009e617
to
4984aa0
Compare
This PR introduces a restructuring of the data source definition within ngeo and gmf to allow the upcoming new "file" data source type.
In summary:
ngeo.datasource
andgmf.datasource
namespaces (directories)ngeo.Datasource
has been replaced by:ngeo.datasource.DataSource
- the abstract class for a data sourcengeo.datasource.OGC
- a data source that uses OGC services to fetch/display its datagmf.DataSource
has been replaced bygmf.datasource.OGC
The 'externs' definitions have been updated as well.