search parameter/map_zoom: Test for null to allow 0 as value #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
reviewed
Oct 18, 2017
| @@ -965,7 +965,7 @@ gmf.SearchController.prototype.fulltextsearch_ = function(query, resultIndex, op | |||
| const feature = format.readFeature(data.features[resultIndex - 1]); | |||
| this.featureOverlay_.addFeature(feature); | |||
| const fitOptions = /** @type {olx.view.FitOptions} */ ({}); | |||
| if (opt_zoom) { | |||
| if (opt_zoom !== null) { | |||
There was a problem hiding this comment.
if opt_zoom is not passed to the function, it will be undefined not null
There was a problem hiding this comment.
And the @param for opt_zoom should be changed to:
@param {number=} opt_zoom Optional zoom level.
fredj
reviewed
Oct 18, 2017
| @@ -965,7 +965,7 @@ gmf.SearchController.prototype.fulltextsearch_ = function(query, resultIndex, op | |||
| const feature = format.readFeature(data.features[resultIndex - 1]); | |||
| this.featureOverlay_.addFeature(feature); | |||
| const fitOptions = /** @type {olx.view.FitOptions} */ ({}); | |||
| if (opt_zoom) { | |||
| if (typeof opt_zoom !== 'undefined') { | |||
There was a problem hiding this comment.
can be simplified to if (opt_zoom !== undefined) {
pfirpfel
force-pushed
the
fix-search-param-zoom
branch
from
9c9a1a3
to
a12641b
Compare
|
travis fails (probably) because the branch is from your fork, not the camptocamp one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses @fredj feedback.