gmf-displaywindow Component #3044
Conversation
|
@fredj You can take an early look, if you want. |
|
@fredj Ready for review. See also the "todo" about the desktop_alt. I don't know what's wrong... |
| width: calc(~"100% -" 2 * @app-margin); | ||
| z-index: @above-search-index; | ||
| } | ||
| } |
|
Travis fails, but it seems unrelated this PR. |
|
I've tried to check what could be wrong with desktop_alt but without luck. |
adube
force-pushed
the
122-gmf-displaywindow
branch
from
20a16f9
to
e75d957
Compare
|
Rebased onto master. |
|
The issue with |
Done: #3056. Merging... |
|
Hold on. The issue reported by Travis is correct. I'll fix this first. |
adube
force-pushed
the
122-gmf-displaywindow
branch
from
e75d957
to
cf65d51
Compare
|
Error reported by Travis has been fixed. Remaining errors are unrelated to this PR. Merging... |
|
As I understand this will breaks the c2cgeoportal build... |
|
Why hasn't Travis report this in its last pass here? I'm concerned. For the time being, I'll make a fix asap. It would be very, very nice I could be able to run the checks locally without any errors, or if Travis could behave normally every time... |
|
Nevermind, this has already been fixed here: 542156f |
That's what I'm wondering too ! |
This PR includes a new component that can be used as replacement of the
ngeo.Popup, but with the possibility to make it resizable/draggable.It is used in all 4 apps, instead of the
ngeo.Popup:Todo
The dragging of the window doesn't work in theUnrelated to this PR. Issue created: jQueryUI draggable doesn't work on desktop_alt app #3056desktop_altversion. I have no clue why... Following these recommendations, everything seems to be OK, with my doubts being that something must mess with the event jQuery is supposed to listen. Resizable works fine. See: https://stackoverflow.com/questions/7159118/jquery-ui-draggable-not-working