Fix autorotate #3103
Merged
Fix autorotate #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llienher
force-pushed
the
fix_autorotate
branch
from
60dcef6
to
ba3da65
Compare
sbrunner
reviewed
Nov 27, 2017
src/directives/mobilegeolocation.js
Outdated
| * @private | ||
| */ | ||
| ngeo.MobileGeolocationController.prototype.handleRotate_ = function(eventAlpha, currentAlpha) { | ||
| console.log(eventAlpha, currentAlpha); | ||
| const alpha = eventAlpha; | ||
|
|
||
| if (alpha === undefined || alpha === null) { |
There was a problem hiding this comment.
apha is declared as a number than he can't be null or undefined ...
src/directives/mobilegeolocation.js
Outdated
| @@ -334,11 +334,10 @@ ngeo.MobileGeolocationController.prototype.autorotateListener = function() { | |||
| * Handle rotation. | |||
| * @param {number} eventAlpha . | |||
| * @param {number} currentAlpha . | |||
| * @return {number} currentAlpha . | |||
| * @return {number|undefined} . | |||
There was a problem hiding this comment.
For me it should be just {number}
llienher
force-pushed
the
fix_autorotate
branch
from
31db9a1
to
8210ea7
Compare
fredj
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use native javascript to fetch gyroscope data from mobile devices instead of ol.DeviceOrientation
TODO: