Fix typeahead selection in ImportDataSource component #3126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issue: in the DataSourceBrowser component, the "connect" button was sometimes disabled after the selection of an item.
This was due to the fact that the field itself is of
url
type and there's an angular rule applied on the connect button that automatically disables it if the form is invalid. The selection using the drop-down list uses typeahead. Now, I don't know exactly why, but the selected value was not always properly copied in the model, i.e. it was pasted in the input field, but not the model.This fix ensures that, after the selection of an item among the typeahead selections, the value is properly copied. At the same time, I do a "focus" on the connect button.
This solution keeps the
url
type on the field, because I think it's very useful to ensure that any url either selected or manually typed are valid urls.