Directive to component for examples #3136
Conversation
ghost
self-assigned this
apastuhov
force-pushed
the
feature-GSGMF-151-directive-to-component
branch
from
720cadb
to
152e119
Compare
| }, | ||
| templateUrl: 'partials/backgroundlayer.html', | ||
| controller: 'AppBackgroundlayerController', | ||
| controllerAs: 'ctrl' |
There was a problem hiding this comment.
Can't we remove that ? Then use "$ctrl" in the partial ?
There was a problem hiding this comment.
yes, but then we need to update partials, I am not sure that it is critical and/or should be done in that PR
There was a problem hiding this comment.
That's not critical. That's why we'll probably never do that if we don't do that right now.
But it's not really important. If you think it takes too much time to do the change (and test) leave it like that :-)
There was a problem hiding this comment.
it's fine to leave as it for the examples but it would be nice to do it the all the ngeo and gmf components (in the others pull requests).
There was a problem hiding this comment.
I will do it as another PR on monday
| }, | ||
| templateUrl: 'partials/backgroundlayerdropdown.html', | ||
| controller: 'AppBackgroundlayerController', | ||
| controllerAs: 'ctrl' |
There was a problem hiding this comment.
Same (etc. please verify also in other components)
| * @private | ||
| * @type {angular.JQLite} | ||
| */ | ||
| this.$element = $element; |
There was a problem hiding this comment.
add an underscore if it's private:
this.$element_ = $element;
ghost
merged commit 
https://jira.camptocamp.com/browse/GSGMF-151