GMF Print: Move from directive to component #3155
Conversation
ger-benjamin
force-pushed
the
gmfprint_directive_to_component
branch
2 times, most recently
from
727596b
to
7f74fc8
Compare
ger-benjamin
force-pushed
the
gmfprint_directive_to_component
branch
from
7f74fc8
to
6eb6b74
Compare
| @@ -110,9 +110,9 @@ | |||
| <a class="btn close" ng-click="mainCtrl.printPanelActive = false">×</a> | |||
| </div> | |||
| <gmf-print | |||
| gmf-print-map="mainCtrl.map" | |||
| gmf-print-map="::mainCtrl.map" | |||
There was a problem hiding this comment.
no real need.. gmf-print should use one-way binding
There was a problem hiding this comment.
That's not the same thing.
'<' stand for "one-WAY" bindings.
& (in js) or :: (in html) stand for "one-TIME" binding.
I think the more important is the one-time binding for the map and with FredJ, we find that it's more practical to use the html notation.
There was a problem hiding this comment.
I told to use one-way because you are passing a map object, so profit is not so big.
As for me it makes sense only for some data that will never change like captions and(or) calculated expressions
https://docs.angularjs.org/guide/expression#reasons-for-using-one-time-binding
| /** | ||
| * Init the controller | ||
| */ | ||
| gmf.PrintController.prototype.$onInit = function() { |
There was a problem hiding this comment.
I think we should do that in another PR (that already a big one and all other component still use this notation)
| */ | ||
| this.currentThemes_; | ||
| const getScaleFn = (frameState) => { |
There was a problem hiding this comment.
why not a method? it seems a bit complex arrow-function
There was a problem hiding this comment.
I agree, but that's minor (was a moved code part) and I'm not here tomorrow, if I don't merge now, I'll merge Monday :-/
For GSGMF-155
Work well on example, and apps