gmf-displaywindow - drag/resize on same div #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fredj After trying to change the displayquerywindow as well, I was going with the 'parent div' route and it did not work. It was working for the displaywindow. So, I changed to your solution (used the container instead) and it worked for both. Ready for review. |
fredj
reviewed
Nov 30, 2017
|
@fredj I won't be able to unless you accept the PR :) |
fredj
approved these changes
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
gmf-displaywindowwas made smaller using the jQueryUI resizable widget, the parent div was keeping the original size. That parent div had the jQueryUI draggable widget on it, which allows the window to be dragged even when seemed to be dragging outside the window.To fix this, both widgets now interact with the same div: the first div within the widget (at the root).