WIP - Fix empty disclaimer

[adube]

An issue has been raised about the disclaimer messages in the desktop_alt application. It's now showing an empty message. It seems to be a combinaison of multiple things. Here goes.

First issue

First, when the update to Angular 1.6 was made, changes were made in several directives to change them as components without them being tested. The gmf-disclaimer was one of them. Look at the first commit of this PR. The component was created before its controller. From this point moment on, the component stop from working under the 'development' environment. When compiled, it worked because I suppose the compiler was smart enough to understand to define the controller before and then use it, I don't know...

Introduced in #2142

Fixed in the "first step" commit.

Second issue

This PR doesn't have any fix for this yet, as I don't understand how it works...

The second issue was caused when moving the modal from a directive to a component, see:

#3154

Prior this, the modal was shown fine.

When not using the external option of the disclaimer, it's working fine (we have disclaimer messages correctly shown at the bottom left of the map). When using it (that's what the desktop_alt app does), it's showing the empty messages.

From what I understand, we define a ngeo-modal that uses a custom defined model that's shared between the modal and disclaimer... and the visibility as well. I don't understand how that's supposed to work now with components (nor how that was working before), as I'm not used to this kind of practice.

[fredj]

@adube I'm on the second issue

[fredj]

@adube I've found the issue with gmf-modal pull request to come

[adube]

@fredj great, thanks!

[fredj]

@adube see #3211 for the second issue, it was related to the transclude handling in ngeo-modal.

[fredj]

I suspect that the previous code in ngeo-modal was specially designed to confuse others devs (or scare small children)

[adube]

Hahaha, it did scare me a little :)