Modularize recenter #3204
Modularize recenter #3204
Conversation
src/recenter/directive.js
Outdated
| */ | ||
| ngeo.recenter.directive = angular.module('ngeoRecenter', []); | ||
|
|
||
| const ngeoModule = ngeo.module; |
There was a problem hiding this comment.
I understand why I have to create this const, but not why it was not required in the gmf.search.component...
There was a problem hiding this comment.
@ger-benjamin, no it is not correct to use this const here: you can not create a local constant, in a goog.provide file.
Do you have an error when using ngeo.module directly?
examples/recenter.js
Outdated
| goog.require('ol.Map'); | ||
| goog.require('ol.View'); | ||
| goog.require('ol.layer.Tile'); | ||
| goog.require('ol.source.OSM'); | ||
|
|
||
| goog.require('ngeo.recenter.module'); |
There was a problem hiding this comment.
According to https://jira.camptocamp.com/browse/GSGMF-172 the recenter directive is part of the map top level module. So in theory I would expect the map module to be required here.
@sbrunner, what do you think about it? Should examples require the top level modules or directly the directives they use?
There was a problem hiding this comment.
In the applications we will use in priority the tom level module, I think that's should be the same in the examples :-)
src/recenter/directive.js
Outdated
| @@ -1,7 +1,15 @@ | |||
| goog.provide('ngeo.recenterDirective'); | |||
| goog.provide('ngeo.recenter.directive'); | |||
There was a problem hiding this comment.
Should be in src/map/recenter.js. @sbrunner, do you want to add a note in https://jira.camptocamp.com/browse/GSGMF-172 explaining the files need to be renamed (not moved in a directive subdirectory)?
Then the symbol should be ngeo.map.recenter. (I would drop the directive suffix).
src/recenter/directive.js
Outdated
| */ | ||
| ngeo.recenter.directive = angular.module('ngeoRecenter', []); | ||
|
|
||
| const ngeoModule = ngeo.module; |
There was a problem hiding this comment.
@ger-benjamin, no it is not correct to use this const here: you can not create a local constant, in a goog.provide file.
Do you have an error when using ngeo.module directly?
src/recenter/module.js
Outdated
| /** | ||
| * @module ngeo recenter namespace | ||
| */ | ||
| goog.provide('ngeo.recenter.module'); |
There was a problem hiding this comment.
This module is not necessary (there is no recenter top level module). You can recycle it by renaming it ngeo.map.module and moving it there if it does not already exist.
src/recenter/directive.js
Outdated
| @@ -1,7 +1,15 @@ | |||
| goog.provide('ngeo.recenterDirective'); | |||
| goog.provide('ngeo.recenter.directive'); | |||
ger-benjamin
force-pushed
the
modularize_recenter
branch
from
8194ca2
to
70b4560
Compare
ger-benjamin
force-pushed
the
modularize_recenter
branch
from
70b4560
to
158a551
Compare
For GSGMF https://jira.camptocamp.com/browse/GSGMF-174