Adapt angular: ngeo.query #3290
Conversation
pfirpfel
force-pushed
the
adapt-angular-ngeo-query
branch
from
90342b3
to
56b2350
Compare
src/query/Querent.js
Outdated
| @@ -1,17 +1,23 @@ | |||
| goog.provide('ngeo.Querent'); | |||
| /** | |||
| * @module ngeo query namespace | |||
There was a problem hiding this comment.
what's that ? Do you know ?
There was a problem hiding this comment.
We should not put @module annotations; they will be generated automatically later (in a specific format).
src/query/bboxquerydirective.js
Outdated
| /** | ||
| * @module ngeo query namespace | ||
| */ | ||
| goog.provide('ngeo.query.bboxQueryDirective'); |
There was a problem hiding this comment.
Event if that's always an angular directive, can you names it "component ?".
That's a more generic term and In the future, we will change it to a component. So we (and our customers in their custom code) will have to update again the require.
(Also for other directives in this PR)
| @@ -3,7 +3,7 @@ goog.provide('gmf.QueryManager'); | |||
| goog.require('ol.events'); | |||
| goog.require('gmf'); | |||
| goog.require('gmf.Themes'); | |||
| goog.require('ngeo.Query'); | |||
| goog.require('ngeo.query.Query'); | |||
There was a problem hiding this comment.
ngeo.query.Service ? query Query looks weird (In my own opinion)
src/query/mapquerydirective.js
Outdated
|
|
||
| ngeo.module.requires.push(ngeo.query.mapQueryDirective.module.name); | ||
|
|
||
| ngeo.query.mapQueryDirective.module.directive('ngeoMapQuery', ngeo.query.mapQueryDirective); |
There was a problem hiding this comment.
I think we said to export the Angular module for directives and components (not the directive function).
ngeo.query.mapQueryDirective = angular.module('ngeoMapQuery', [
ngeo.query.MapQuerent.name,
]);
There was a problem hiding this comment.
+1
This file is strange. That should be:
ngeo.query.mapQueryDirective = angular.module...
ngeo.module.requires....
...
ngeo.query.mapQueryDirective.directive_ = function...
...
ngeo.query.mapQueryDirective.directive('ngeoMapQuery', ngeo.query.mapQueryDirective.directive_);
no ?
pfirpfel
force-pushed
the
adapt-angular-ngeo-query
branch
from
c5f2b70
to
5a30029
Compare
pfirpfel
force-pushed
the
adapt-angular-ngeo-query
branch
from
5a30029
to
de494df
Compare
No description provided.