Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows issues #3300

Merged
merged 1 commit into from
Dec 21, 2017
Merged

fix windows issues #3300

merged 1 commit into from
Dec 21, 2017

Conversation

monodo
Copy link

@monodo monodo commented Dec 20, 2017

This PR:

  • Updates the Windows_makefile
  • Proposes a fix in order to have jsdoc run on windows. Basically, the file names to be parsed by jsdoc are no longer passed to the windows command but injected into the jsdoc config file as windows does not support long command strings (...)

Known issue: this file will appear as modified in git after dist build.

@fredj: would you like to review and merge ?

@fredj fredj self-assigned this Dec 20, 2017
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredj fill free to merge it when travis tests pass :-)

@fredj fredj merged commit 8c9728b into camptocamp:master Dec 21, 2017
@sbrunner sbrunner added this to the 2.3 milestone Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants