Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt angular ngeo.editing #3308

Merged
merged 6 commits into from
Jan 8, 2018
Merged

Adapt angular ngeo.editing #3308

merged 6 commits into from
Jan 8, 2018

Conversation

pfirpfel
Copy link
Contributor

No description provided.

@pfirpfel pfirpfel self-assigned this Dec 21, 2017
@pfirpfel pfirpfel changed the title [wip] Adapt angular ngeo.editing Adapt angular ngeo.editing Jan 3, 2018
@pfirpfel
Copy link
Contributor Author

pfirpfel commented Jan 3, 2018

todo:
src/directives/exportfeatures.js (extra)

@pfirpfel pfirpfel removed the Ongoing label Jan 3, 2018
ger-benjamin
ger-benjamin approved these changes Jan 3, 2018
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also must name the src/editing/attributes.html file to src/editing/attributesComponent.html.

But for me you can merge and address my both comment in another PR (f.i. the one you'll use to move the exportfeatures extra service)

src/editing/createfeaturecomponent.js Outdated
@@ -15,6 +16,12 @@ goog.require('ol.style.Style');
// Don't forget to add module dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line please

@ger-benjamin
Copy link
Member

ger-benjamin commented Jan 3, 2018 •
edited
Loading

You do not have a extraModule.js (for the extra service) ?

@pfirpfel
Copy link
Contributor Author

pfirpfel commented Jan 3, 2018

I will add this asap.

@pfirpfel
Copy link
Contributor Author

pfirpfel commented Jan 3, 2018

Found a typo (added here as a todo):

ngeo/src/misc/extraModule.js

Line 20 in bf08afe

ngeo.misc.extaModule = angular.module('ngeoMiscExtraModule', [

@ger-benjamin
Copy link
Member

Nice catch, thanks !

@ger-benjamin ger-benjamin mentioned this pull request Jan 3, 2018
Merged
@pfirpfel pfirpfel added this to the 2.3 milestone Jan 3, 2018
ger-benjamin
ger-benjamin approved these changes Jan 8, 2018
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)

@pfirpfel pfirpfel removed the Ongoing label Jan 8, 2018
@ger-benjamin ger-benjamin mentioned this pull request Jan 8, 2018
Merged
@pfirpfel pfirpfel merged commit ae970bd into camptocamp:master Jan 8, 2018
@pfirpfel pfirpfel deleted the adapt-angular-ngeo-editing branch January 8, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

@ger-benjamin ger-benjamin ger-benjamin approved these changes

Assignees

@pfirpfel pfirpfel

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pfirpfel @ger-benjamin @fredj