Create gmf editing module #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfirpfel
approved these changes
Jan 9, 2018
gberaudo
reviewed
Jan 9, 2018
| goog.require('gmf.ObjectEditingManager'); | ||
| goog.require('gmf.theme.Themes'); | ||
| goog.require('gmf.XSDAttributes'); | ||
| /** @suppress {extraRequire} */ | ||
| goog.require('ngeo.proj.EPSG21781'); |
There was a problem hiding this comment.
For curiosity, do you know why this projection is required? It is not used in the file.
There was a problem hiding this comment.
no idea... there is no map in this file :-/
Perhaps an artifact. I'll remove it in my next commit.
ger-benjamin
force-pushed
the
create_gmf_editing_module
branch
from
24fc8ce
to
4af88f2
Compare
ger-benjamin
force-pushed
the
create_gmf_editing_module
branch
from
4af88f2
to
0f70a75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: https://jira.camptocamp.com/browse/GSGMF-238