Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt angular gmf.import #3362

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Adapt angular gmf.import #3362

merged 2 commits into from
Jan 11, 2018

Conversation

pfirpfel
Copy link
Contributor

No description provided.

@pfirpfel pfirpfel added this to the 2.3 milestone Jan 10, 2018
@pfirpfel pfirpfel self-assigned this Jan 10, 2018
ger-benjamin
ger-benjamin reviewed Jan 10, 2018
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You use twice the string 'gmfImportdatasource'. I don't think that's problematic because both are in different context. Can you verify if the examples are working well ?

@pfirpfel
Copy link
Contributor Author

pfirpfel commented Jan 11, 2018 •
edited
Loading

@ger-benjamin I just tried contribs/gmf/examples/importdatasource.js, it works fine.

ger-benjamin
ger-benjamin approved these changes Jan 11, 2018
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot this PR.
Please merge :-)

@pfirpfel pfirpfel merged commit 0658960 into camptocamp:master Jan 11, 2018
@pfirpfel pfirpfel deleted the adapt-angular-gmf-import branch January 11, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ger-benjamin ger-benjamin ger-benjamin approved these changes

@fredj fredj Awaiting requested review from fredj

@gberaudo gberaudo Awaiting requested review from gberaudo

Assignees

@pfirpfel pfirpfel

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pfirpfel @ger-benjamin