Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to configure the mobile measure format #3372

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Jan 11, 2018

fix #3254

@sbrunner sbrunner added this to the 2.2 milestone Jan 11, 2018
@@ -29,6 +30,10 @@ ngeo.interaction.MeasurePointMobile = function(format, opt_options) {
*/
this.format_ = format;

/**
* @type {string}
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: missing @private

Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to demo it by changing the mobile_alt interface

@sbrunner
Copy link
Member Author

+1

@rbovard
Copy link
Contributor

rbovard commented Jan 11, 2018

Thanks a lot @sbrunner!

@sbrunner sbrunner force-pushed the mobile-measure-format branch 4 times, most recently from 97161b1 to c34a6dd Compare January 12, 2018 15:01
@sbrunner sbrunner merged commit b341902 into 2.2 Jan 12, 2018
@sbrunner sbrunner deleted the mobile-measure-format branch January 12, 2018 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants