Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build all ngeo examples #3379

Merged
merged 2 commits into from
Jan 22, 2018
Merged

Build all ngeo examples #3379

merged 2 commits into from
Jan 22, 2018

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Jan 12, 2018

@sbrunner sbrunner force-pushed the examples branch 15 times, most recently from 09d4211 to 0fc9bf3 Compare January 16, 2018 09:25
@sbrunner sbrunner added this to the 2.3 milestone Jan 16, 2018
@sbrunner sbrunner force-pushed the examples branch 2 times, most recently from 0b2beea to bbe1a6d Compare January 16, 2018 15:06
@sbrunner sbrunner changed the title Build all ngeo examples [WIP] Build all ngeo examples Jan 18, 2018
@sbrunner sbrunner force-pushed the examples branch 7 times, most recently from f00d235 to dbe92f0 Compare January 19, 2018 15:14
@sbrunner sbrunner force-pushed the examples branch 6 times, most recently from e0a4edc to 651cdfb Compare January 20, 2018 12:15
@sbrunner sbrunner changed the title [WIP] Build all ngeo examples Build all ngeo examples Jan 22, 2018
@sbrunner sbrunner force-pushed the examples branch 3 times, most recently from 5c12167 to 2551e20 Compare January 22, 2018 11:19
Makefile Outdated
@@ -730,16 +729,28 @@ node_modules/angular/angular.min.js: .build/node_modules.timestamp
--app 'Object editing editor' apps/oeedit/index.html 'An example application for editing an object.' \
$< $(GMF_EXAMPLES_HTML_FILES) > $@

.build/examples-hosted/%.html: \
.build/examples-hosted/%.css \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing body? -> remove the \ or remove the rule.

Makefile Outdated
@@ -752,7 +763,9 @@ node_modules/angular/angular.min.js: .build/node_modules.timestamp
.build/node_modules.timestamp: package.json
@# re-installing the node packages, while 'make serve' is still running
@# might freeze the system. ask for confirmation in that case.
@if ps -a | grep node; then \
@if ps a | grep -v grep | grep 'node buildtools/serve.js'; then \
echo "Conserned process:"; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Affected

@sbrunner sbrunner merged commit 0186843 into master Jan 22, 2018
@sbrunner sbrunner deleted the examples branch January 22, 2018 16:29
sbrunner added a commit that referenced this pull request Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants