-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build all ngeo examples #3379
Merged
Build all ngeo examples #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
force-pushed
the
examples
branch
15 times, most recently
from
January 16, 2018 09:25
09d4211
to
0fc9bf3
Compare
sbrunner
force-pushed
the
examples
branch
2 times, most recently
from
January 16, 2018 15:06
0b2beea
to
bbe1a6d
Compare
sbrunner
force-pushed
the
examples
branch
7 times, most recently
from
January 19, 2018 15:14
f00d235
to
dbe92f0
Compare
sbrunner
force-pushed
the
examples
branch
6 times, most recently
from
January 20, 2018 12:15
e0a4edc
to
651cdfb
Compare
sbrunner
force-pushed
the
examples
branch
3 times, most recently
from
January 22, 2018 11:19
5c12167
to
2551e20
Compare
gberaudo
approved these changes
Jan 22, 2018
Makefile
Outdated
@@ -730,16 +729,28 @@ node_modules/angular/angular.min.js: .build/node_modules.timestamp | |||
--app 'Object editing editor' apps/oeedit/index.html 'An example application for editing an object.' \ | |||
$< $(GMF_EXAMPLES_HTML_FILES) > $@ | |||
|
|||
.build/examples-hosted/%.html: \ | |||
.build/examples-hosted/%.css \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing body? -> remove the \
or remove the rule.
Makefile
Outdated
@@ -752,7 +763,9 @@ node_modules/angular/angular.min.js: .build/node_modules.timestamp | |||
.build/node_modules.timestamp: package.json | |||
@# re-installing the node packages, while 'make serve' is still running | |||
@# might freeze the system. ask for confirmation in that case. | |||
@if ps -a | grep node; then \ | |||
@if ps a | grep -v grep | grep 'node buildtools/serve.js'; then \ | |||
echo "Conserned process:"; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Affected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on gberaudo/googshift#6