Move gmf displaywindow to ngeo message #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
approved these changes
Jan 16, 2018
ger-benjamin
force-pushed
the
Move_gmf_displaywindow_to_ngeo_message
branch
2 times, most recently
from
8dfda4f
to
7e22aa4
Compare
ger-benjamin
force-pushed
the
Move_gmf_displaywindow_to_ngeo_message
branch
from
7e22aa4
to
babd630
Compare
Yes, that would be nice. Every ngeo component should have one. |
|
Ok, I merge and I ask ybolognini to know what I must do. (Because that's not part of the ES6 tasks/budget) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: https://jira.camptocamp.com/browse/GSGMF-245
Constat: displaywindow is in gmf but must be in ngeo.
Problem: displaywindow use displayquerywindow
I move the component and change the css to be able to use the same css but without duplicating the css rule.
Now, the displaywindow component is in the ngeo.messaage module. Should I do an example in ngeo ?