Create gmf datasource module #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfirpfel
approved these changes
Jan 17, 2018
| @@ -1,23 +0,0 @@ | |||
| goog.provide('gmf.datasource.DataSourceBeingFiltered'); | |||
There was a problem hiding this comment.
The renaming for this file got lost.
contribs/gmf/src/datasource/DatasourceBeingFiltered.js
There was a problem hiding this comment.
It's because it's nearly empty and I've changed everything... I think I can't proceed differently.
There was a problem hiding this comment.
To make it work, you would have to split the move and the change of content into two commits. It is annoying...
There was a problem hiding this comment.
Done, but I'm not sure if that have changed something (except that I have good clear conscience).
ger-benjamin
force-pushed
the
move_gmf_datasource_module
branch
from
690d9e1
to
1ef03d5
Compare
ger-benjamin
force-pushed
the
move_gmf_datasource_module
branch
from
1ef03d5
to
1e5f6e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: https://jira.camptocamp.com/browse/GSGMF-247
I've changed more "...DataSource..." into "Datasource" than expected for this task but that's really specific, I think it will not break customers custom code. And it's better with an unified notation. (Even if there is still a lot of work to unifiy the notation between both usage)too messy. I'll go back