Unbind datasource from map #3400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ger-benjamin
force-pushed
the
unbind_datasource_in_map
branch
2 times, most recently
from
64036c8
to
9ffa6ca
Compare
ger-benjamin
force-pushed
the
unbind_datasource_in_map
branch
from
f894aa5
to
3c32abb
Compare
ger-benjamin
force-pushed
the
unbind_datasource_in_map
branch
from
3c32abb
to
bf57481
Compare
To unbind the hard link between datasources and the map.
ger-benjamin
force-pushed
the
unbind_datasource_in_map
branch
from
bf57481
to
347231e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: GSGMF-150
First commit:
The Aim is to remove the dependence between the map and the datasource. For that, the best I found is to transforms the ngeoDataSources into a service in which we give a map. (In this way, I found that the best is to transform the SyncDataSourcesMap into this ngeoDataSources component. Because both will require each others an do the same job)
Second commit for GSGMF-196 (export map directive as a component)