Add require of goog.assert #3469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For me this file should be moved in option and will be used only by gcc or completely remove in the webpack migration ... |
ger-benjamin
force-pushed
the
add_goog_require
branch
3 times, most recently
from
73c1067
to
098a997
Compare
|
For the last commit, I've taken what was done for saccas. But I've improvised methods for AssertFunction, nassertObject, assertArray and assertElement. Because the code was not existing. |
ger-benjamin
force-pushed
the
add_goog_require
branch
from
098a997
to
c581610
Compare
sbrunner
approved these changes
Feb 1, 2018
src/goog.asserts.js_
Outdated
| @@ -191,9 +191,9 @@ exports.assertFunction = function(value, opt_message, var_args) { | |||
| * @throws {goog.asserts.AssertionError} When the value is not an object. | |||
| */ | |||
| exports.assertObject = function(value, opt_message, var_args) { | |||
| if (exports.ENABLE_ASSERTS && !goog.isObject(value)) { | |||
| if (exports.ENABLE_ASSERTS && (value === null || typeof value != 'object')) { | |||
There was a problem hiding this comment.
!Array.isArray(value) && typeof value == 'object' && value != null || typeof value == 'function';
src/goog.asserts.js_
Outdated
| @@ -248,9 +248,9 @@ exports.assertBoolean = function(value, opt_message, var_args) { | |||
| */ | |||
| exports.assertElement = function(value, opt_message, var_args) { | |||
| if (exports.ENABLE_ASSERTS && | |||
| (!goog.isObject(value) || value.nodeType != goog.dom.NodeType.ELEMENT)) { | |||
| (value === null || typeof value != 'object' || value.nodeType == undefined)) { | |||
ger-benjamin
force-pushed
the
add_goog_require
branch
from
c581610
to
aae33b8
Compare
ger-benjamin
force-pushed
the
add_goog_require
branch
from
aae33b8
to
9fa797a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will still fail because of:
Case 1: goog.exportSymbol
https://github.com/camptocamp/ngeo/blob/master/src/jstsexports.js#L14
Any idea ?
Case 2: goog.
https://github.com/camptocamp/ngeo/blob/master/src/goog.asserts.js_#L139 (and brothers)
Can I use
typeof(value) === "number"?What should I do ?