-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify windows makefile #3500
Unify windows makefile #3500
Conversation
I will test it this afternoon and give you a feedback. Moreover, we discovered with @monodo that it was really easier to code for NGEO in a Linux environment, but I really appreciate being able to build it in Windows. |
@gberaudo, I tested this PR, and I had to apply following change for it to work:
With these modifications, I am able to run But running |
bec795d
to
52f0068
Compare
@kalbermattenm, I updated the PR, could you please test again? |
52f0068
to
018f8c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1089 line removed !
I'll test it again on Wednesday and give you a feedback. |
@kalbermattenm |
Travis passing, I am going to merge now. @kalbermattenm, let me know if there is something not working on your side and it will be fixed in a follow up PR. |
With a tiny change of the main Makefile it looks possible to handle Windows build.
@kalbermattenm, would you be able to test this change before I merge it?