Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify windows makefile #3500

Merged
merged 4 commits into from
Feb 27, 2018
Merged

Unify windows makefile #3500

merged 4 commits into from
Feb 27, 2018

Conversation

gberaudo
Copy link
Member

@gberaudo gberaudo commented Feb 9, 2018

With a tiny change of the main Makefile it looks possible to handle Windows build.
@kalbermattenm, would you be able to test this change before I merge it?

@kalbermattenm
Copy link
Contributor

I will test it this afternoon and give you a feedback.

Moreover, we discovered with @monodo that it was really easier to code for NGEO in a Linux environment, but I really appreciate being able to build it in Windows.

@kalbermattenm
Copy link
Contributor

@gberaudo, I tested this PR, and I had to apply following change for it to work:
image

make is not a Windows cmd, it is running inside a Cygwin environment and in Windows, the Python executable is python.exe whatever version you use. Thus if I leave the -python python3, then make tries to use the Python distribution which is installed with Cygwin and this one has not enough rights to write on the disk. So the only thing I did was to be sure to have Python3 in my path.

With these modifications, I am able to run make dist without any error.

But running make serve triggers an weird error and I do not know if that has something to do with Windows or if this is a general error:

image

@gberaudo
Copy link
Member Author

@kalbermattenm, I updated the PR, could you please test again?

Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1089 line removed !

@kalbermattenm
Copy link
Contributor

I'll test it again on Wednesday and give you a feedback.

@kalbermattenm
Copy link
Contributor

Weird, I get another error now when running make dist (after make cleanall)

image

@gberaudo
Copy link
Member Author

@kalbermattenm make dist is broken on all platforms. If it is the only issue, then I will merge.

@gberaudo
Copy link
Member Author

Travis passing, I am going to merge now. @kalbermattenm, let me know if there is something not working on your side and it will be fixed in a follow up PR.

@gberaudo gberaudo merged commit 2e8c3b9 into master Feb 27, 2018
@gberaudo gberaudo deleted the unify_windows_makefile branch February 27, 2018 12:40
@sbrunner sbrunner added this to the 2.3 milestone Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants