Remove unused vars 2 #3527
Merged
Remove unused vars 2 #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
approved these changes
Feb 15, 2018
ger-benjamin
force-pushed
the
remove_unused_vars_2
branch
from
db700b9
to
cc1efab
Compare
ger-benjamin
force-pushed
the
remove_unused_vars_2
branch
2 times, most recently
from
1330dd4
to
2310989
Compare
|
To debug the tests, I went back on the use of EPSG21781 as variable in the tests. Because I still have work on tests and I'll see this problem later. |
sbrunner
reviewed
Feb 15, 2018
| @@ -39,6 +39,7 @@ describe('ngeo.misc.AutoProjection', () => { | |||
| const coordinatesA = [600000, 200000]; | |||
| const coordinatesB = [8, 47]; | |||
| const viewProjection = ol.proj.get('EPSG:21781'); | |||
| debugger; | |||
ger-benjamin
force-pushed
the
remove_unused_vars_2
branch
from
2310989
to
dbe7aa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://jira.camptocamp.com/browse/GSGMF-261
Still to fix (in a next PR):
~50 / 300+ warnings left