Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make apps #3552

Merged
merged 5 commits into from
Feb 21, 2018
Merged

Make apps #3552

merged 5 commits into from
Feb 21, 2018

Conversation

ger-benjamin
Copy link
Member

@ger-benjamin ger-benjamin commented Feb 21, 2018 •
edited
Loading

For https://jira.camptocamp.com/browse/GSGMF-281

Now all apps works (at least as the desktop) without webpack

Also now, we have only unused warning (after the webpack-migration script) on test files !

@ger-benjamin ger-benjamin added this to the 2.3 milestone Feb 21, 2018
@ger-benjamin ger-benjamin self-assigned this Feb 21, 2018
sbrunner
sbrunner approved these changes Feb 21, 2018
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

@ger-benjamin ger-benjamin merged commit 3a73569 into master Feb 21, 2018
@ger-benjamin ger-benjamin deleted the make_apps branch February 21, 2018 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

@pfirpfel pfirpfel Awaiting requested review from pfirpfel

@gberaudo gberaudo Awaiting requested review from gberaudo

Assignees

@ger-benjamin ger-benjamin

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ger-benjamin @sbrunner