Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't load mainmodule in examples #3587

Merged
merged 3 commits into from
Feb 28, 2018
Merged

Don't load mainmodule in examples #3587

merged 3 commits into from
Feb 28, 2018

Conversation

fredj
Copy link
Member

@fredj fredj commented Feb 27, 2018

ger-benjamin
ger-benjamin approved these changes Feb 27, 2018
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ger-benjamin
Copy link
Member

(I've restarted the build, it was timed out)

@sbrunner
Copy link
Member

Why?

@fredj
Copy link
Member Author

fredj commented Feb 28, 2018

Because we want the examples to load only what they need; not everything from gmf

@sbrunner
Copy link
Member

This is to have a big part in the commons part and It's also what we want ...

@fredj fredj merged commit eadfdb5 into master Feb 28, 2018
@fredj fredj deleted the GSGMF-219 branch February 28, 2018 13:04
@sbrunner sbrunner added this to the 2.3 milestone Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ger-benjamin ger-benjamin ger-benjamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@fredj @ger-benjamin @sbrunner