Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused import in tests #3591

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Remove unused import in tests #3591

merged 1 commit into from
Feb 28, 2018

Conversation

ger-benjamin
Copy link
Member

@ger-benjamin ger-benjamin commented Feb 28, 2018

For: https://jira.camptocamp.com/browse/GSGMF-261

The last unused vars (except 2 projections in test, but that will be done later)
(All file was already loaded)

@ger-benjamin
Copy link
Member Author

Note:

In the not-webpack-transformed version, there is still these warning, I think I can't remove any more:

/home/bgerber/Documents/ngeo/src/ngeo.js
  11:1  warning  Expected goog.provide('ngeo.index') to be at ngeo/index.js instead of ngeo/ngeo.js  googshift/valid-provide-and-module
  15:1  warning  Unused goog.require('ol.format.IGC');                                               googshift/no-unused-requires
  17:1  warning  Unused goog.require('ol.source.Raster');                                            googshift/no-unused-requires
  19:1  warning  Unused goog.require('ol.VectorTile');                                               googshift/no-unused-requires
  21:1  warning  Unused goog.require('ol.Overlay');                                                  googshift/no-unused-requires
  23:1  warning  Unused goog.require('ol.control.ScaleLine');                                        googshift/no-unused-requires
  25:1  warning  Unused goog.require('ol.source.WMTS');                                              googshift/no-unused-requires
  27:1  warning  Unused goog.require('ol.style.Icon');                                               googshift/no-unused-requires
  29:1  warning  Unused goog.require('ol.layer.VectorTile');                                         googshift/no-unused-requires
  32:1  warning  Unused goog.require('ol.Map');                                                      googshift/no-unused-requires
  34:1  warning  Unused goog.require('ol.source.Vector');                                            googshift/no-unused-requires
  36:1  warning  Unused goog.require('ol.render.Feature');                                           googshift/no-unused-requires
  38:1  warning  Unused goog.require('ol.source.VectorTile');                                        googshift/no-unused-requires
  40:1  warning  Unused goog.require('ol.style.AtlasManager');                                       googshift/no-unused-requires

/home/bgerber/Documents/ngeo/src/proj/epsg32631.js
  6:1  warning  Unused goog.require('ol.proj.proj4');  googshift/no-unused-requires

/home/bgerber/Documents/ngeo/src/proj/epsg21781.js
  6:1  warning  Unused goog.require('ol.proj.proj4');  googshift/no-unused-requires

/home/bgerber/Documents/ngeo/src/proj/epsg2154.js
  6:1  warning  Unused goog.require('ol.proj.proj4');  googshift/no-unused-requires

/home/bgerber/Documents/ngeo/src/proj/epsg3947.js
  6:1  warning  Unused goog.require('ol.proj.proj4');  googshift/no-unused-requires

/home/bgerber/Documents/ngeo/src/proj/epsg27572.js
  6:1  warning  Unused goog.require('ol.proj.proj4');  googshift/no-unused-requires

/home/bgerber/Documents/ngeo/src/proj/epsg2056.js
  6:1  warning  Unused goog.require('ol.proj.proj4');  googshift/no-unused-requires

/home/bgerber/Documents/ngeo/test/spec/beforeeach.js
  3:1  warning  Expected goog.provide('app') to be at app.js instead of ngeo/test/beforeeach.js  googshift/valid-provide-and-module

/home/bgerber/Documents/ngeo/test/spec/services/autoprojection.spec.js
  1:1  warning  Unused goog.require('ngeo.proj.EPSG21781');  googshift/no-unused-requires

/home/bgerber/Documents/ngeo/contribs/gmf/src/gmf.js
  1:1  warning  Expected goog.provide('gmf') to be at gmf.js instead of gmf/gmf.js  googshift/valid-provide-and-module

/home/bgerber/Documents/ngeo/contribs/gmf/src/objectediting/component.js
  13:1  warning  Unused goog.require('ngeo.jstsExports');  googshift/no-unused-requires

/home/bgerber/Documents/ngeo/contribs/gmf/apps/appmodule.js
  6:1  warning  Expected goog.provide('app') to be at app.js instead of apps/appmodule.js  googshift/valid-provide-and-module

/home/bgerber/Documents/ngeo/contribs/gmf/apps/desktop_alt/js/controller.js
  7:1  warning  Expected goog.provide('app.desktop_alt.Controller') to be at app/desktop_alt/controller.js instead of apps/desktop_alt/js/controller.js  googshift/valid-provide-and-module

/home/bgerber/Documents/ngeo/contribs/gmf/apps/oeview/js/controller.js
  7:1  warning  Expected goog.provide('app.oeview.Controller') to be at app/oeview/controller.js instead of apps/oeview/js/controller.js  googshift/valid-provide-and-module

/home/bgerber/Documents/ngeo/contribs/gmf/apps/mobile/js/controller.js
  7:1  warning  Expected goog.provide('app.mobile.Controller') to be at app/mobile/controller.js instead of apps/mobile/js/controller.js  googshift/valid-provide-and-module

/home/bgerber/Documents/ngeo/contribs/gmf/apps/mobile_alt/js/controller.js
  7:1  warning  Expected goog.provide('app.mobile_alt.Controller') to be at app/mobile_alt/controller.js instead of apps/mobile_alt/js/controller.js  googshift/valid-provide-and-module

/home/bgerber/Documents/ngeo/contribs/gmf/apps/oeedit/js/controller.js
  7:1  warning  Expected goog.provide('app.oeedit.Controller') to be at app/oeedit/controller.js instead of apps/oeedit/js/controller.js  googshift/valid-provide-and-module

/home/bgerber/Documents/ngeo/contribs/gmf/apps/desktop/js/controller.js
  7:1  warning  Expected goog.provide('app.desktop.Controller') to be at app/desktop/controller.js instead of apps/desktop/js/controller.js  googshift/valid-provide-and-module

@ger-benjamin ger-benjamin merged commit 8ce0255 into master Feb 28, 2018
@ger-benjamin ger-benjamin deleted the remove_unused_in_test branch February 28, 2018 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants