Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update googshift and olcs #3627

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Update googshift and olcs #3627

merged 1 commit into from
Mar 7, 2018

Conversation

gberaudo
Copy link
Member

@gberaudo gberaudo commented Mar 6, 2018

No description provided.

@gberaudo gberaudo requested a review from sbrunner March 6, 2018 14:14
@sbrunner
Copy link
Member

sbrunner commented Mar 7, 2018

To be rebased ...

@gberaudo gberaudo force-pushed the fix_olcs_dependency branch 2 times, most recently from 90cadd1 to 377e151 Compare March 7, 2018 08:42
@gberaudo
Copy link
Member Author

gberaudo commented Mar 7, 2018

done

@@ -134,6 +134,7 @@ const config = {
'moment': 'moment/src/moment.js',
'ol/ol.css': 'openlayers/css/ol.css',
'ol': 'openlayers/src/ol',
'goog': 'olcs/goog/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, this is a remaining from when I was on an old branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok :-)

@gberaudo gberaudo merged commit 98e2944 into master Mar 7, 2018
@gberaudo gberaudo deleted the fix_olcs_dependency branch March 7, 2018 11:21
@sbrunner sbrunner added this to the 2.3 milestone Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants