Print - Selected scale must not be auto. adapted #3649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ger-benjamin
force-pushed
the
selected_scale_must_not_change
branch
from
f8553ee
to
484e609
Compare
|
@ger-benjamin I have updated https://gmf-test.sig.cloud.camptocamp.net/wkaltz22 and the test case I had works now (1:1000), thanks. |
|
Also close: #3458 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: GEO-1051
Summary:
If the scale 1:1000 is never the "best calculated scale" for the print, the scale will be automatically adapted. Than means, we will never be able print in 1:1000. This PR correct that.
@jwkaltz can you test if that's the expected behaviors ? I've taken the same client-scale/print-scale than your, as explained in your comment, in the ticket.
@fredj can you valid the code ?
Demo here: https://gmf-test.sig.cloud.camptocamp.net/bge