[WIP] Transform code to es6 #3797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the minDate and maxDate initialization in the datepicker option object
Fix rules operator translation
Translate the disclaimer
sbrunner
reviewed
Apr 24, 2018
karma-conf.js
Outdated
| @@ -7,7 +7,6 @@ var isDebug = process.argv.some(function(argument) { | |||
| }); | |||
|
|
|||
| module.exports = function(config) { | |||
| var closureLibPath = 'node_modules/google-closure-library/'; | |||
There was a problem hiding this comment.
This will be replace by the webpack version ...
gberaudo
force-pushed
the
transform_code_to_es6_GSGMF-445
branch
from
10d61e3
to
a4357c0
Compare
Better 'no result' display in search
Add missing double support
|
That's because of this kind of PR that Github statistics are so useless 😅 |
|
+12,023 −22,632 |
gberaudo
force-pushed
the
transform_code_to_es6_GSGMF-445
branch
3 times, most recently
from
0db6d89
to
6a7b81f
Compare
gberaudo
force-pushed
the
transform_code_to_es6_GSGMF-445
branch
2 times, most recently
from
64bcbea
to
17df57f
Compare
Use jQuery to synchronize rotation inputs
gberaudo
force-pushed
the
transform_code_to_es6_GSGMF-445
branch
from
f0baed1
to
01d521d
Compare
sbrunner
approved these changes
Apr 25, 2018
Makefile
Outdated
| @@ -274,6 +276,15 @@ examples-hosted: \ | |||
| examples-hosted-gmf \ | |||
| examples-hosted-apps | |||
|
|
|||
| .build/examples-hosted/%: .build/node_modules.timestamp $(FONTAWESOME_WEBFONT) $(ANGULAR_LOCALES_FILES) | |||
| NODE_ENV=dev TARGET=ngeo-examples node_modules/.bin/webpack --progress | |||
There was a problem hiding this comment.
This will run webpack for each examples ...
package.json
Outdated
| @@ -103,6 +103,7 @@ | |||
| "walk": "2.3.13", | |||
| "webpack": "4.6.0", | |||
| "webpack-cli": "2.0.15", | |||
| "webpack-dev-server": "^3.1.3", | |||
Keep output path for hosted examples
Use a timestamp to track when a build has been done. Depend on all example files to trigger a new build on any change.
Without this comment, the rule is like ignored.
For unknown reason, OpenLayers needs rbush which needs quickselect which is not found by webpack without adding it to our package.json.
This reverts commit db84b85.
They work locally on the dev machine. They fail in Travis at some point. These Travis issues should not block the migration.
The gmf apps are not yet migrated to webpack
gberaudo
force-pushed
the
transform_code_to_es6_GSGMF-445
branch
from
7290332
to
dcd77e3
Compare
sbrunner
added a commit
that referenced
this pull request
Apr 26, 2018
Simplification of Transform code to es6 #3797
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about moving the code base to ES6 modules and switching to a webpack buildchain.
The Google Closure Compiler buildchain is abandonned (at least for now).