Fix gmf examples #3835
Merged
Fix gmf examples #3835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llienher
force-pushed
the
fix_gmf_examples
branch
2 times, most recently
from
ce208d5
to
5d3118d
Compare
llienher
force-pushed
the
fix_gmf_examples
branch
5 times, most recently
from
a96c117
to
976a259
Compare
gberaudo
approved these changes
May 3, 2018
| @@ -162,7 +162,7 @@ exports.Controller_.prototype.handleFeatureSet_ = function( | |||
| keys.push( | |||
| olEvents.listen( | |||
| newFeature, | |||
| olObject.getChangeEventType(propName), | |||
| getChangeEventType(propName), | |||
There was a problem hiding this comment.
We should create the string ourselves: change:${propName}.
See also the other files below where you should do for ex: 'change:dirty' and remove the imports.
src/map/FeatureOverlayMgr.js
Outdated
| @@ -7,7 +7,7 @@ import * as olBase from 'ol/index.js'; | |||
| import olLayerVector from 'ol/layer/Vector.js'; | |||
| import * as olObj from 'ol/obj.js'; | |||
| import olSourceVector from 'ol/source/Vector.js'; | |||
| import olStyleStyle, {toFunction as toStyleFunction} from 'ol/style/Style.js'; | |||
| import olStyleStyle, {toFunction as toStyleFunction, createDefaultStyle as defaultFunction} from 'ol/style/Style.js'; | |||
There was a problem hiding this comment.
Better call it olStyleDefaultFunction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix several gmf examples:
Fix ngeo example:
Also various fixes for gmf apps.