Fix editfeatureselector example #3846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llienher
commented
May 4, 2018
buildtools/webpack.commons.js
Outdated
| use: { | ||
| loader: 'expose-loader', | ||
| options: 'DateFormatter' | ||
| } | ||
| }; | ||
| };*/ |
There was a problem hiding this comment.
@sbrunner Do you prefer we remove these lines or we keep it what a additional informative comment ?
sbrunner
reviewed
May 4, 2018
buildtools/webpack.commons.js
Outdated
| @@ -165,7 +165,7 @@ const config = { | |||
| olcsRule, | |||
| angularRule, | |||
| typeaheadRule, | |||
| dateFormatterRule, | |||
| // dateFormatterRule, | |||
sbrunner
reviewed
May 4, 2018
buildtools/webpack.commons.js
Outdated
| 'proj4': 'proj4/lib', | ||
| 'jquery-datetimepicker$': 'jquery-datetimepicker/jquery.datetimepicker.js', |
sbrunner
reviewed
May 4, 2018
src/misc/php-date-formatter.js
Outdated
| } | ||
| }; | ||
|
|
||
| export default DateFormatter; |
llienher
force-pushed
the
fix_edit-feature_example
branch
4 times, most recently
from
f270e0d
to
d3364b9
Compare
gberaudo
approved these changes
May 4, 2018
llienher
force-pushed
the
fix_edit-feature_example
branch
from
d3364b9
to
5096431
Compare
sbrunner
pushed a commit
that referenced
this pull request
May 4, 2018
Fix editfeatureselector example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stéphane converted the php-date-formatter lib into a webpack custom supported version we can use find in the src/misc directory. Other changes are minor syntax errors in webpack configs and import of css.