Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lidarprofile 23 #3855

Merged
merged 7 commits into from
May 9, 2018
Merged

Conversation

ger-benjamin
Copy link
Member

@ger-benjamin ger-benjamin commented May 7, 2018

This PR superseeds #3842, that superseeds original #3464. It convert lidarprofile to ngeo 2.3 (and is based with your last fixes @kalbermattenm , I've merged them into one commit)

WIP: The example works fine, but I can't test the app now, because gmf apps doens't work for now in ngeo.

@ger-benjamin ger-benjamin self-assigned this May 7, 2018
@ger-benjamin ger-benjamin added this to the 2.3 milestone May 7, 2018
@ger-benjamin
Copy link
Member Author

Works fine now on desktop apps except for two things:

@sbrunner
Copy link
Member

sbrunner commented May 9, 2018

What about changing the projection in the desktop alt?

@kalbermattenm
Copy link
Contributor

We (SITN) cannot, for sure, provide data in EPSG:21781...

@sbrunner Where should I define this value in the new architecture ?

What about creating a fake webservice, serving always the same points, which would be a bit odd, but which would removing a dependency from your webservice... (we could even add some doc about that in the example)

@ger-benjamin
Copy link
Member Author

What about changing the projection in the desktop alt ?

As we have discussed, that's not so simple, because all widget that use the raster service (for elevation) will not work anymore, there is also also work with the background, a little bit for the search.
That's not impossible but that take a little bit time.

Can't we re-projecte coordinates from the map to the lidar profile ?

That not so simple because we need to reproject the line AND the "mouseover" that display the information popup...

What about creating a fake webservice ?

It's a possibility.


IMO, we should revert changes in the desktop_alt. So we will not have the Lidar Profile for now in our application desktop. We know that it works, you can see the revert commit to implement it into your application if you need it.
And if you want a demo, the example still works (contribs/gmf/example/lidarprofile).
And later, we re-add the Lidar profile in the desktop_alt.

@ger-benjamin
Copy link
Member Author

@sbrunner @kalbermattenm Is this idea ok for you ? (I hope merging this afternoon)

@kalbermattenm
Copy link
Contributor

+1, effectively, it looks like the easy way to resolve this problem.

@ger-benjamin
Copy link
Member Author

Done, I've made a specific commit that add, and another that revert what we need to add in the application files to have the Lidar profile (see the two lasts commits).

I'll merge 🎉

@ger-benjamin ger-benjamin merged commit b012c7d into camptocamp:master May 9, 2018
@ger-benjamin ger-benjamin deleted the lidarprofile_23 branch May 9, 2018 12:11
@ger-benjamin ger-benjamin changed the title WIP Lidarprofile 23 Lidarprofile 23 May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants