Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3.4 wms styles #4228

Closed
wants to merge 6 commits into from
Closed

2.3.4 wms styles #4228

wants to merge 6 commits into from

Conversation

svareg
Copy link
Contributor

@svareg svareg commented Sep 12, 2018

Hello,

In the Admin Tool of C2CGeoportal, we can set a "style" for a layer (i.e. the ClassGroup defined on MapServer). But in Ngeo, this value is never used.

In this Pull Request, I've corrected this missing parameter evaluation in Ngeo, so that the "style" values that comes with the themes.json will be correctly passed to the layer configuration.

Is it possible for you to verify this code (I don't know ngeo really good, and I perhaps missed something) and merge it with the next 2.3.X Version ?

If you have any question, just ask!

Thanks,
Guillaume.

@sbrunner
Copy link
Member

The files
/contribs/gmf/fonts/gmf-icons.eot
/contribs/gmf/fonts/gmf-icons.ttf
/contribs/gmf/fonts/gmf-icons.woff
Shouldn't be added in the repository...
the tag commit should be removed :-)

@svareg
Copy link
Contributor Author

svareg commented Sep 13, 2018

Hello Stéphane,

Sorry, I made this commit after the pull request, on the wrong branch.
I don't exactly understand what you mean with "the tag commit should be removed", so I just revert my last commit.

I also corrected the errorts found by travis.

Hope this is ok for you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants