Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In the Admin Tool of C2CGeoportal, we can set a "style" for a layer (i.e. the ClassGroup defined on MapServer). But in Ngeo, this value is never used.
In this Pull Request, I've corrected this missing parameter evaluation in Ngeo, so that the "style" values that comes with the themes.json will be correctly passed to the layer configuration.
Is it possible for you to verify this code (I don't know ngeo really good, and I perhaps missed something) and merge it with the next 2.3.X Version ?
If you have any question, just ask!
Thanks,
Guillaume.