Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set nodata values to null and not 0 #4246

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Set nodata values to null and not 0 #4246

merged 1 commit into from
Sep 19, 2018

Conversation

julsbreakdown
Copy link
Member

@julsbreakdown julsbreakdown force-pushed the gmf_profile_tool_deal_with_no_data branch 2 times, most recently from c74271b to 446285b Compare September 19, 2018 06:41
fredj
fredj reviewed Sep 19, 2018
View reviewed changes
src/profile/d3Elevation.js Outdated
@@ -407,7 +407,9 @@ const exports = function(options) {
// Configure the d3 line.
line = d3.line()
.x(d => x(distanceExtractor(d)))
.y(d => y(linesConfiguration[name].zExtractor(d)));
.y(d => y(linesConfiguration[name].zExtractor(d)))
.defined(d => d.value);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be clearer if the condition is changed to: .defined(d => d.value !== null)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks

@julsbreakdown julsbreakdown force-pushed the gmf_profile_tool_deal_with_no_data branch from 446285b to 44912e3 Compare September 19, 2018 09:28
fredj
fredj approved these changes Sep 19, 2018
View reviewed changes
Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, please merge

@julsbreakdown julsbreakdown merged commit 52c7cb6 into 2.3 Sep 19, 2018
@julsbreakdown julsbreakdown deleted the gmf_profile_tool_deal_with_no_data branch September 19, 2018 10:37
@sbrunner sbrunner added this to the 2.3 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@julsbreakdown @fredj @sbrunner