Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message modal dialog in editFeatureComponent #4376

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Fix error message modal dialog in editFeatureComponent #4376

merged 1 commit into from
Nov 21, 2018

Conversation

arnaud-morvan
Copy link
Member

I don't know why $parent was there, it probably works some time.
But it does not works anymore and efCtrl is used directly everywhere in this file since 2 years.

@arnaud-morvan
Copy link
Member Author

@julsbreakdown: Can you have a look here, I need an approve to merge.

@arnaud-morvan arnaud-morvan merged commit 0ca6a05 into 2.3 Nov 21, 2018
@arnaud-morvan arnaud-morvan deleted the fix_edit_feature_modal branch November 21, 2018 09:38
@sbrunner sbrunner added this to the 2.3 milestone Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julsbreakdown julsbreakdown julsbreakdown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@arnaud-morvan @julsbreakdown @sbrunner