Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In flush mode load current theme private groups on login #4817

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

arnaud-morvan
Copy link
Member

@arnaud-morvan arnaud-morvan commented Apr 11, 2019

To keep things simple, I simply reload current theme when in flush mode and no default_theme for the user.
This have no impact on "not flush" mode.

@arnaud-morvan arnaud-morvan force-pushed the GSGMF-858-flush_current_theme_on_login branch from b58e135 to 8da1a9d Compare April 11, 2019 14:37
@sbrunner
Copy link
Member

It doesn't work in this case:

  • Load theme Mixt
  • Search for filtres
  • Add data filtres

=> Groups: Filtres, Function OSM

  • Login with demo

=> Groups: Private, Function OSM
Expected groups (Order?): Filtres, Function OSM, Private

@arnaud-morvan
Copy link
Member Author

Note that this also occurs when there is a default_theme configured for the user.

@sbrunner
Copy link
Member

Yes but it's wanted in the case of default_theme ...

@arnaud-morvan arnaud-morvan force-pushed the GSGMF-858-flush_current_theme_on_login branch from 8da1a9d to d12294e Compare April 15, 2019 14:05
@arnaud-morvan
Copy link
Member Author

Should be better now, only add private first level group at end of layer tree. Finally not so complex.

@arnaud-morvan arnaud-morvan force-pushed the GSGMF-858-flush_current_theme_on_login branch from d12294e to 7d9911a Compare April 15, 2019 14:09
@sbrunner
Copy link
Member

For me it's OK, I let @fredj to have a third look :-)

Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@arnaud-morvan arnaud-morvan changed the title In flush mode reload current theme on login In flush mode load current theme private groups on login Apr 15, 2019
@arnaud-morvan arnaud-morvan force-pushed the GSGMF-858-flush_current_theme_on_login branch from 7d9911a to 6e0a90a Compare April 15, 2019 16:05
@arnaud-morvan arnaud-morvan merged commit f09b85d into 2.3 Apr 16, 2019
@arnaud-morvan arnaud-morvan deleted the GSGMF-858-flush_current_theme_on_login branch April 16, 2019 10:51
@sbrunner sbrunner added this to the 2.3 milestone Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants