Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite possibly pending ngeoMapQuerent state [2.3] #4887

Merged
merged 1 commit into from
May 9, 2019
Merged

Don't overwrite possibly pending ngeoMapQuerent state [2.3] #4887

merged 1 commit into from
May 9, 2019

Conversation

pfirpfel
Copy link
Contributor

@pfirpfel pfirpfel commented May 9, 2019

Bugfix from #4852

I wanted to show a different cursor if there is a pending map query. But query/windowComponent (formerly displayquerywindow) keeps clearing ngeoQueryResult right after MapQuerent.issue() gets called. This clearing is not distinguishable from a unsuccessful query.

@pfirpfel pfirpfel requested a review from fredj May 9, 2019 13:15
@pfirpfel pfirpfel mentioned this pull request May 9, 2019
Closed
@pfirpfel pfirpfel merged commit 32f7a92 into camptocamp:2.3 May 9, 2019
@pfirpfel pfirpfel deleted the preserve-mapquerent-state-2.3 branch May 9, 2019 13:35
@pfirpfel pfirpfel added this to the 2.3 milestone May 9, 2019
@pfirpfel pfirpfel self-assigned this May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

Assignees

@pfirpfel pfirpfel

Labels
None yet
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@pfirpfel @fredj