Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add floor selector component #4950

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Add floor selector component #4950

merged 1 commit into from
Jun 20, 2019

Conversation

arnaud-morvan
Copy link
Member

No description provided.

@sbrunner
Copy link
Member

You add it to the desktop alt, but is there a way to test it on the gh-pages?

@arnaud-morvan
Copy link
Member Author

You should already view on it on gh-pages, but it will have no effect.
I can open a pull request on demo_geomapfish 2.4 with new mapserver layer, and we might add it in admin interface.

@sbrunner sbrunner added this to the 2.4.1 milestone Jun 14, 2019
@arnaud-morvan arnaud-morvan force-pushed the floorselector branch 2 times, most recently from 411e609 to fd1170b Compare June 17, 2019 10:53
@arnaud-morvan arnaud-morvan changed the title [WIP] Add floor selector component Add floor selector component Jun 17, 2019
@arnaud-morvan
Copy link
Member Author

@sbrunner @fredj
It is now available on gh pages : https://camptocamp.github.io/ngeo/floorselector/examples/contribs/gmf/apps/desktop_alt
I get a CORS error on the themes request, so I cannot see my new layer configured with the floor slider component.
You can use the up and down buttons, click on the floors or use the mouse wheel.
Note that we might debounce between mousewheel and changing layer parameters.

@arnaud-morvan
Copy link
Member Author

Sorry, in fact it does not works on server side for the moment, waiting for an openshift demo 2.4 update after merge of new layer.

@sbrunner
Copy link
Member

Cool, cela marche nikel :-)
https://camptocamp.github.io/ngeo/floorselector/examples/contribs/gmf/apps/desktop_alt.html?dim_FLOOR=8&lang=fr&tree_groups=OSM%20functions%20mixed%2CLayers%2CGroup%2COSM%20functions%2CExternal%2CFilters%20mixed%2CFilters%2CFloor%20slider&tree_group_opacity_Group=0.65&tree_enable_osm_scale=false&tree_group_layers_Layers=&tree_group_layers_Group=&tree_group_layers_OSM%20functions=&tree_enable_ch.swisstopo.dreiecksvermaschung=false&tree_enable_ch.swisstopo.geologie-gravimetrischer_atlas=false&tree_enable_ch.swisstopo.geologie-geotechnik-gk500-lithologie_hauptgruppen=false&tree_enable_ch.swisstopo.geologie-geotechnik-gk500-gesteinsklassierung=false&tree_enable_Batiment%20VD%20noWFS=false&tree_enable_ch.bfe.solarenergie-eignung-fassaden=false&tree_enable_ch.bfe.solarenergie-eignung-daecher=false&tree_enable_osm_open=false&tree_enable_OSM%20map=false&tree_enable_osm_time_r_dp_2=false&tree_group_layers_Filters=&tree_group_layers_Floor%20slider=floor_slider&baselayer_ref=OSM%20map&baselayer_opacity=0&tree_enable_Layer%20with%20very%20very%20very%20very%20very%20long%20name=false&tree_enable_osm_time_r_s=false&tree_enable_osm_time_v_s=false&tree_enable_osm_time_v_dp=false&tree_enable_osm_time_r_dp=false&tree_enable_osm_time_r_year_mounth=false&tree_enable_osm_time_d_year_mounth=false&tree_enable_osm_time_r_mounth_year=false&tree_enable_osm_time_v_mounth_year=false&tree_enable_long%20wms-t%20layer%20name%20name%20name%20name%20name%20name%20name=false&tree_enable_osm_time_r_dp_default=false&tree_enable_osm_time_r_s_default=false&tree_enable_osm_time_v_dp_default=false&tree_enable_osm_time_v_s_default=false&tree_enable_two_layers=false&tree_enable_ch.astra.ausnahmetransportrouten=false&tree_enable_no_wfs=false&map_x=573552&map_y=137885&map_zoom=2

@arnaud-morvan
Copy link
Member Author

I've added the comments but I do not see the component in api doc. Do you want to investigate, or should we merge ?

@arnaud-morvan
Copy link
Member Author

I got it in api doc locally, should appears in minutes on gh pages, just missing an approve now.

@arnaud-morvan
Copy link
Member Author

@sbrunner @fredj : if no more comments, just missing an approve to merge this PR.

@arnaud-morvan arnaud-morvan merged commit 247533e into 2.4 Jun 20, 2019
@arnaud-morvan arnaud-morvan deleted the floorselector branch June 20, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants